[workspace] Use host OS VTK 9.1 when on Ubuntu 22.04 #18340
Conversation
jwnimmer-tri
force-pushed
the
jammy-vtk
branch
from
085cf64 to
00b638d
Compare
|
@drake-jenkins-bot linux-jammy-unprovisioned-clang-bazel-experimental-release please |
|
@drake-jenkins-bot linux-jammy-gcc-bazel-experimental-release please |
jwnimmer-tri
added
priority: high
release notes: fix
|
I've confirmed that this fixes our TRI-internal CI build errors for Jammy + VTK + OpenCV + etc: +@rpoyner-tri for feature review, please. Or @svenevs you're welcome to take over feature review, if you have time. +@EricCousineau-TRI for platform review per schedule, please. |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee rpoyner-tri(platform), labeled "do not merge" (waiting on @jwnimmer-tri and @rpoyner-tri)
a discussion (no related file):
nit Worth porting opencv_pydrake_test to Drake to confirm?
tools/workspace/vtk/build_binaries_with_docker line 49 at r1 (raw file):
build focal --build-arg PLATFORM=ubuntu:20.04 extract focal
nit Worth comment stating why Jammy isn't necessary?
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, labeled "do not merge" (waiting on @jwnimmer-tri)
This change all builds on Jammy except for wheel builds.
jwnimmer-tri
force-pushed
the
jammy-vtk
branch
from
00b638d to
e22b584
Compare
There was a problem hiding this comment.
Reviewable status: labeled "do not merge" (waiting on @EricCousineau-TRI and @rpoyner-tri)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit Worth porting
opencv_pydrake_testto Drake to confirm?
Even better, I can re-enable the OpenCV movie-streaming unit tests now.
tools/workspace/vtk/build_binaries_with_docker line 49 at r1 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
nit Worth comment stating why Jammy isn't necessary?
Done.
|
@drake-jenkins-bot linux-jammy-clang-bazel-experimental-debug please |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: labeled "do not merge" (waiting on @jwnimmer-tri)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Even better, I can re-enable the OpenCV movie-streaming unit tests now.
Sweet!
…#18340) This change all builds on Jammy except for wheel builds.
|
I ran into some issues with this change when I was rebuilding. I was getting messages down the lines of (I'm not really commenting asking for anything, just putting it out here in case someone else runs into the issue.) |
|
Thanks! |
…#18340) This change all builds on Jammy except for wheel builds.
This changes all builds on Jammy except for wheel builds.
This change is