Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes setup bug where Pip attempts to install a downgraded Numpy (
<2
) on top of Brew's installednumpy@2
on MacOS, which results in:To reproduce the above error, simply run:
./setup/mac/install_prereqs.sh
.This PR takes one viable approach by simply allowing Pip to disregard what Brew has already installed and install its own numpy version.
Currently I apply this change for all packages installed in the run of pip associated with the numpy install.
This can be updated to limit this call to only the numpy install.
I will note this is essentially the nuclear option here and could potentially cause slight increases in setup times if the overlap between Brew and pip is substantial.
Alternatively, we can use Pip's
--no-build-isolation
and virtual environments to build numpy in isolation from Brew's python similar to how Spack does thingsThis change is