Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py optimization] Fix option name in unit test #21902

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Sep 13, 2024

Towards #21345. CLP will soon starting barking about unknown options.

Amends #18875.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: medium status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Sep 13, 2024
@jwnimmer-tri
Copy link
Collaborator Author

+@RussTedrake for both reviews, please (follow-up from #18875).

FYI @wrangelvid in case you have any suggestions.

Copy link
Contributor

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: x2. The "dual" option (obviously) wasn't doing any work. log_level is just as good.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee RussTedrake(platform)

@RussTedrake RussTedrake merged commit 4ac314f into RobotLocomotion:master Sep 14, 2024
9 checks passed
@jwnimmer-tri jwnimmer-tri deleted the py-test-option-name branch September 15, 2024 00:18
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants