-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[solvers] Add missing unit tests for options handling #21939
[solvers] Add missing unit tests for options handling #21939
Conversation
dfe1a44
to
b7e7dfd
Compare
+@hongkai-dai for feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee hongkai-dai, needs platform reviewer assigned, needs at least two assigned reviewers
solvers/test/mosek_solver_test.cc
line 300 at r1 (raw file):
bas_file); solver.Solve(prog, {}, solver_options, &result); EXPECT_TRUE(std::filesystem::exists({log_file}));
Should we check the existence of the bas_file
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee hongkai-dai, needs platform reviewer assigned, needs at least two assigned reviewers
solvers/test/mosek_solver_test.cc
line 300 at r1 (raw file):
Previously, hongkai-dai (Hongkai Dai) wrote…
Should we check the existence of the
bas_file
?
Yes, I forgot to check that. However, I can't get MOSEK to write to that file, or any other string-option file for that matter.
Can you think of any https://docs.mosek.com/10.1/capi/parameters.html#doc-sparam-list options that we could set and see some effect from, either in a file or a change to the solution result?
b7e7dfd
to
d81520a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee hongkai-dai, needs platform reviewer assigned, needs at least two assigned reviewers
solvers/test/mosek_solver_test.cc
line 300 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Yes, I forgot to check that. However, I can't get MOSEK to write to that file, or any other string-option file for that matter.
Can you think of any https://docs.mosek.com/10.1/capi/parameters.html#doc-sparam-list options that we could set and see some effect from, either in a file or a change to the solution result?
I tried a half dozen string options, and none of them wrote anything. AA couldn't think of an option to test, either. So instead, I've rewritten the test code to clarify that all we are doing is smoke testing lack of crashes, on purpose.
+@sammy-tri for platform review per schedule, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee sammy-tri(platform)
solvers/test/mosek_solver_test.cc
line 300 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
I tried a half dozen string options, and none of them wrote anything. AA couldn't think of an option to test, either. So instead, I've rewritten the test code to clarify that all we are doing is smoke testing lack of crashes, on purpose.
Sorry I somehow missed this PR. Thanks for the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees sammy-tri(platform),hongkai-dai
In preparation for #21345.
This change is