Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup] Upgrade Python venv (mac) to latest #22165

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

nicolecheetham
Copy link
Contributor

@nicolecheetham nicolecheetham commented Nov 13, 2024

Towards #22087

The mac job fails with TypeError: BaseEventLoop.create_connection() got an unexpected keyword argument 'timeout'. When traced the file where the issue occurs is meshcat_websocket_client.py.

This PR updates websockets from 13.1 to 14. The new version of websockets has backwards incompatible changes. Websockets Changelog

The Ubuntu jammy images use 9.1

Link indicating how to update: https://websockets.readthedocs.io/en/stable/howto/upgrade.html


This change is Reviewable

@nicolecheetham nicolecheetham added status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Nov 13, 2024
@rpoyner-tri rpoyner-tri self-assigned this Nov 14, 2024
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri for review and maybe fixups.

Reviewable status: LGTM missing from assignee rpoyner-tri(platform)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: pending mac ci and squash

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

@rpoyner-tri rpoyner-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Nov 14, 2024
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

@rpoyner-tri rpoyner-tri merged commit 50fcd24 into RobotLocomotion:master Nov 14, 2024
9 checks passed
@nicolecheetham nicolecheetham deleted the upgrade_python branch November 26, 2024 17:53
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Co-Authored-By: nicole.cheetham <nicole.cheetham@tri-macmini-02.kitware.com>
Co-Authored-By: Rick Poyner <rick.poyner@tri.global>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants