Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify upgrade advice for bazelisk #22171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify upgrade advice for bazelisk #22171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/workspace/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ Once all upgrades are ready, open a Drake pull request and label it
change the drop-down that says "Combine commits for review" to choose
"Review each commit separately" instead.

If any packages suggested that additional pre-merge testing is needed,
launch jobs as specified in the output of ``new_release``.

Once all of the Jenkins builds of the pull request have passed, assign the
pull request for review. If the pull request contains no especially complicated
changes, it may be assigned to the on-call platform reviewer and labelled
Expand Down
2 changes: 2 additions & 0 deletions tools/workspace/bazelisk/repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ def bazelisk_repository(
Additionally, you must manually update the version number in
setup/ubuntu/source_distribution/install_bazelisk.sh
and adjust the expected checksums accordingly.

To fully test, a Linux uprovisioned job must be launched from the pull request.
""",
commit = "v1.22.1",
sha256 = "64b584d1019d54cde34123d8da06c718c7a7c591f9fd49a29dccb825b9e95e8c", # noqa
Expand Down