-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3: Support Python2 for lcm when being used by drake_visualizer #9699
python3: Support Python2 for lcm when being used by drake_visualizer #9699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jamiesnape for review when you have a chance, please.
Let me know if there's a better packaging solution than this.
Reviewable status: all discussions resolved, platform LGTM missing
Need to fix |
1945eab
to
5710965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed ctypes.cdll
issue, but CI is showing stale results, possibly due to GitHub outages.
Reviewable status: all discussions resolved, LGTM missing from assignee jamiesnape, platform LGTM missing
Re-adding "do not merge"; forgot that some of the code has "DO NOT MERGE" bits to exemplify what config could look like. |
Would it be crazy to ship our pre-built |
Not crazy at all if we keep LCM reasonably in sync (keeping on a tag would be nice). |
I think we only really care about wire compatibility in this case anyway, so the definition of “reasonably in sync” is loose. |
Aye, that'd work. How do we want to formulate that objective? Should I make a separate issue, or should we just track it under #8352? Will close this PR once we do that. |
Create a separate issue and assign it to me. I assume the Python sources for the lcmtypes are 2/3 compatible? |
Seems that way; shall do! |
Shall be superseded by the solution to #9764 |
For #8352
Towards #9614
Allows us to use Python2 builds of
director
when building other stuff with Python3.Install for Python2+3, using this setup script:
Admittedly, the
py2_py3
macro may be a little too cute for now. If we think it's OK to just always compile LCM in Python2 + Python3, I could just manually expand those targets.This change is