Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node v18 & v19 #884

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add support for node v18 & v19 #884

merged 1 commit into from
Nov 17, 2022

Conversation

wayneparrott
Copy link
Collaborator

Enables rclnodejs to run on Node v18 and v19.

Updated:

  • package.json -
  • binding.gyp - upgrade to use c++17
  • updated README and BUILD docs to reference Node 18 & 19
  • gihub actions updated to include Node 18 & 19 in compatibility tests for linux and windows

Fix #382 #383

minggangw
minggangw approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this quick action for the nodejs change, lgtm!

@minggangw minggangw merged commit 681cdea into RobotWebTools:develop Nov 17, 2022
This was referenced Nov 17, 2022
Closed
Closed
minggangw pushed a commit that referenced this pull request Nov 18, 2022
@wayneparrott @minggangw
Add support for node v18 & v19 (#884)
dbafc3a 
Enables rclnodejs to run on Node v18 and v19.

Updated:

package.json -
binding.gyp - upgrade to use c++17
updated README and BUILD docs to reference Node 18 & 19
gihub actions updated to include Node 18 & 19 in compatibility tests for linux and windows

Fix #382 #383
@vela-io vela-io mentioned this pull request Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggangw minggangw minggangw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wayneparrott @minggangw