Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Classes to use Prototype #11

Closed
rctoris opened this issue Mar 18, 2013 · 3 comments
Closed

Convert Classes to use Prototype #11

rctoris opened this issue Mar 18, 2013 · 3 comments
Assignees
@baalexander
Labels
enhancement

Comments

@rctoris
Copy link
Contributor

rctoris commented Mar 18, 2013

As with the issue in ros3djs... name says it all :octocat:
@ghost ghost assigned rctoris Mar 18, 2013
@baalexander
Copy link
Contributor

I didn't realize you had already assigned this to you @rctoris, but I converted roslibjs to use prototypes in my branch (diff here).

I couldn't get the build to work (opening an issue) and will build and test after I get that working. In the mean time, if you want to use the changes on your end, the Merging Locally instructions explains how.

@baalexander
Copy link
Contributor

Fixed in Pull Request #13.

@baalexander
Copy link
Contributor

Reopening until merged.

@baalexander baalexander reopened this Mar 19, 2013
@rctoris rctoris closed this as completed Mar 20, 2013
@ghost ghost assigned baalexander May 7, 2013
k-aguete pushed a commit to k-aguete/roslibjs that referenced this issue Oct 21, 2022
@baalexander
Merge pull request RobotWebTools#11 from rctoris/devel
58e8adf 
continuous flag in OccupancyGridClient fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baalexander baalexander

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baalexander @rctoris