Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis by GH actions #392

Merged
merged 4 commits into from
Apr 4, 2021
Merged

Replace travis by GH actions #392

merged 4 commits into from
Apr 4, 2021

Conversation

MatthijsBurgh
Copy link
Contributor

@MatthijsBurgh MatthijsBurgh commented Jan 8, 2021

Actions need to be enabled by maintainers

@MatthijsBurgh
Copy link
Contributor Author

@jihoonl We need to change the branch protection rules to merge this. Could you do this or give me the rights to do this? (In case you update my rights, maybe best to keep this equal for roslibjs, ros2djs, and ros3djs.)

@jihoonl
Copy link
Member

jihoonl commented Apr 4, 2021

@MatthijsBurgh I just disbled the travis ci from the branch protection rule. Would it be fine?

@MatthijsBurgh
Copy link
Contributor Author

@jihoonl Yes we can merge this one. After the actions have completed, we should require GitHub actions to succeed in the branch protection.

@MatthijsBurgh MatthijsBurgh merged commit 5645b4c into RobotWebTools:develop Apr 4, 2021
@jihoonl
Copy link
Member

jihoonl commented Apr 4, 2021

You should be able to control all as of now. I reconfigure your rights to make it simple.

@jihoonl
Copy link
Member

jihoonl commented Apr 4, 2021

@MatthijsBurgh what's your npm account?

@MatthijsBurgh
Copy link
Contributor Author

@jihoonl I think it is the same as my GitHub username

@jihoonl
Copy link
Member

jihoonl commented Apr 4, 2021

@MatthijsBurgh Ok thanks. you should have received the npm org invitation.

@MatthijsBurgh
Copy link
Contributor Author

@jihoonl I haven't received the npm invite yet. I am not sure npm is case sensitive. My npm account is 'matthijsburgh'

@MatthijsBurgh MatthijsBurgh deleted the patch-2 branch April 4, 2021 09:59
@MatthijsBurgh
Copy link
Contributor Author

@jihoonl I got 9 invites 😄, Invite accepted

@jihoonl
Copy link
Member

jihoonl commented Apr 4, 2021

@MatthijsBurgh Ooops. 😅

You should have access to the npm modules as of now too. 😉

MatthijsBurgh added a commit that referenced this pull request Jun 20, 2021
* Add GitHub Actions

* (actions) fix typo

* (actions) add checkout

* Delete .travis.yml
k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
Bumps [grunt-karma](https://github.com/karma-runner/grunt-karma) from 2.0.0 to 4.0.2.
- [Release notes](https://github.com/karma-runner/grunt-karma/releases)
- [Changelog](https://github.com/karma-runner/grunt-karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/grunt-karma@v2.0.0...v4.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants