Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RockYou Adapter: Ad Size / Multiple Ad Unit update #1

Merged
merged 4 commits into from
Feb 26, 2018

Conversation

cameronhotchkies
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Updated the RockYou Adapter to support:

  • sizes coming from the mediaTypes object.
  • an updated inventory zone
  • multiple AdUnits
  • Test parameters have been updated (including in the README)
{
    code: 'banner-div',
    mediaTypes: {
      banner: {
        sizes: [[720, 480]]
      }
    },

    bids: [{
          bidder: 'rockyou',
          params: {
            placementId: '4954'
          }
        }]
  },

  // Video (outstream)
  {
    code: 'video-outstream',
    mediaTypes: {
      video: {
        context: 'outstream',
        playerSize: [720, 480]
      }
    },
    bids: [{
      bidder: 'rockyou',
      params: {
        placementId: '4957'
      }
    }]
  }

Note: no prebid doc changes are required for this PR

@cameronhotchkies cameronhotchkies changed the title Zone change update RockYou Adapter: Ad Size / Multiple Ad Unit update Jan 30, 2018
@cameronhotchkies
Copy link
Author

cameronhotchkies commented Feb 1, 2018

Ref internal RY tickets:

  • ADS-1362
  • ADS-1363
  • ADS-1364
  • ADS-1365 (incomplete)

@cameronhotchkies cameronhotchkies merged commit c64503e into master Feb 26, 2018
ArmandChoy pushed a commit that referenced this pull request Apr 18, 2018
* RockYou Adapter: Added RockYou Adapter supporting Prebid 1.0

* RockYou Adapter: Removed extraneous imports, replaced a for loop w/ forEach for variable scoping.

* RockYou Adapter: Updated the size handling to allow for multiple size definitions to be handled successfully

* RockYou Adapter: Ad Size / Multiple Ad Unit update (#1)

RockYou Adapter:  
* Updated to support size coming from the mediaTypes object, multiple AdUnit support
* RockYou Adapter: Readme updates
* RockYou Adapter: explicitly pass request.bidId in the response object
* RockYou Adapter: Updated sync URL
ArmandChoy pushed a commit that referenced this pull request May 15, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* Pulsepoint Bid Adapter - GDPR support

* minor update

* minor update

* Fixing review comment
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* GDPR Bug Fix with String response

* minor
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* GDPR Bug Fix with String response

* minor

* Fixing iframe page test

* Fixing lint error
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* PET-239 IAS bid adapter multiple slot fix (#1)

* PET-239 Fix.
Performs the request for multiple slots on 1 call.

* PET-239 Fixed Prebid tests

* PET-239 Additional unit tests

* Fixed errors for PR 2653 (#2)

* Pet 239 ias bid adapter bug fix for multiple slots (#3)

* Fixed errors for PR 2653

* Removed unnecessary block from iasBidAdapter from the comments in pull
2653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants