Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/compile cli #8

Merged
merged 8 commits into from
Sep 14, 2020
Merged

Feat/compile cli #8

merged 8 commits into from
Sep 14, 2020

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Sep 7, 2020

Add the bin/compile.ts script that will compile apps in the Cloud.

We still need to wait for RocketChat/Rocket.Chat.Apps-engine#307 - but the code is ready for review

Other modifications:

  • Rename .ts files to .js files after compile
  • Add implemented interfaces to the app manifest

@d-gubert d-gubert changed the base branch from master to feature/interface-grabber September 7, 2020 23:26
@d-gubert d-gubert requested review from thassiov and shiqimei and removed request for thassiov September 11, 2020 21:36
package.json Outdated Show resolved Hide resolved
@thassiov
Copy link
Contributor

Overall, everything's nice

Copy link
Contributor

@shiqimei shiqimei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated Show resolved Hide resolved
@d-gubert d-gubert marked this pull request as ready for review September 14, 2020 15:30
@d-gubert d-gubert merged commit 5b69bb0 into feature/interface-grabber Sep 14, 2020
@d-gubert d-gubert deleted the feat/compile-cli branch September 14, 2020 15:33
Shailesh351 added a commit to Shailesh351/Rocket.Chat.Apps-compiler that referenced this pull request Jun 15, 2021
[Upstream Catchup] Merge Rocket.Chat.Apps-compiler:master to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants