Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ts compiler #307

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Remove ts compiler #307

merged 4 commits into from
Sep 14, 2020

Conversation

d-gubert
Copy link
Member

What? ⛵

Removing the compilation process for the apps. From this point on, we're expecting the apps package to contain their compiled versions already.

This is just part of the project - most of the work will be done on other packages.

Rocket.Chat PR: RocketChat/Rocket.Chat#18687

Why? 🤔

By doing this we achieve:

  • A smaller dependency tree for the package, since we will not require the typescript package anymore.
  • A smaller memory footprint in the Rocket.Chat server, as we will not load typescript in runtime anymore.
  • A smaller surface for compilation errors to happen when updating the Apps-Engine version in a running server.
  • A shorter start-up time for the Rocket.Chat server, as it will not need to compile all installed apps anymore.
  • A more flexible development experience, not tied to the typescript version we ship with the Apps-Engine.

Links 🌎

PS 👀

@d-gubert d-gubert marked this pull request as draft August 31, 2020 22:27
@d-gubert d-gubert marked this pull request as ready for review September 11, 2020 20:14
Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shiqimei shiqimei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@d-gubert d-gubert merged commit b8701f0 into alpha Sep 14, 2020
@d-gubert d-gubert deleted the remove-ts-compiler branch September 14, 2020 14:11
d-gubert added a commit that referenced this pull request Sep 18, 2020
d-gubert added a commit that referenced this pull request Sep 18, 2020
@d-gubert d-gubert restored the remove-ts-compiler branch September 18, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants