Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Allow user with required permissions to remove member from room #1637

Merged
merged 22 commits into from
May 25, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented May 4, 2018

@RocketChat/ios

Also renames Subscription * Request -> Room * Request. It was starting to get confusing.

Adds test to room roles fetching

Closes #1319

@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@b7516bb). Click here to learn what that means.
The diff coverage is 46.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1637   +/-   ##
=========================================
  Coverage           ?   36.7%           
=========================================
  Files              ?     307           
  Lines              ?   14318           
  Branches           ?       0           
=========================================
  Hits               ?    5256           
  Misses             ?    9062           
  Partials           ?       0
Impacted Files Coverage Δ
...t.Chat/API/Requests/Room/RoomMessagesRequest.swift 0% <ø> (ø)
...et.Chat/API/Requests/Room/RoomMembersRequest.swift 93.54% <ø> (ø)
Rocket.Chat/API/API.swift 72.54% <ø> (ø)
Rocket.Chat/Models/User/UserUtils.swift 100% <ø> (ø)
...ocket.Chat/API/Requests/Room/RoomInfoRequest.swift 91.66% <ø> (ø)
...t.Chat/API/Requests/Room/RoomMentionsRequest.swift 88.88% <ø> (ø)
...cket.Chat/API/Requests/Room/RoomFilesRequest.swift 92.85% <ø> (ø)
Rocket.Chat/Models/Subscription/Subscription.swift 71.42% <ø> (ø)
...llers/Chat/ChatControllerMessageCellProtocol.swift 0% <0%> (ø)
Rocket.Chat/Helpers/Alert.swift 35.18% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7516bb...d3a7ff3. Read the comment docs.

@cardoso cardoso changed the title [WIP][NEW] Allow user with required permissions to remove member from room [NEW] Allow user with required permissions to remove member from room May 21, 2018
@cardoso cardoso requested a review from rafaelks May 21, 2018 17:16
@cardoso
Copy link
Collaborator Author

cardoso commented May 22, 2018

Fixed conflicts and 2 bugs:

  • Not formatting confirmation alert correctly
  • Not refreshing list after removing user

@rafaelks
Copy link
Contributor

@cardoso I don't think I should be able to remove myself from the room 🤔:

simulator screen shot - iphone se - 2018-05-23 at 11 37 38
simulator screen shot - iphone se - 2018-05-23 at 11 37 31

@cardoso
Copy link
Collaborator Author

cardoso commented May 24, 2018

@rafaelks do you think we should remove the option or rename it to "Exit Room" ?

@rafaelks
Copy link
Contributor

@cardoso Yes, let's not open anything to "myself" for now.

@cardoso
Copy link
Collaborator Author

cardoso commented May 25, 2018

@rafaelks Made your changes and fixed conflicts!

didSet {
UIView.performWithoutAnimation {
membersTableView?.reloadData()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing real weird behaviour on the list... we should be adding new rows instead of reloading the entire tableView. But not required right now. 👍

Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelks rafaelks merged commit e56c8c5 into develop May 25, 2018
@rafaelks rafaelks deleted the feat/kick_user.1319 branch May 25, 2018 18:35
@cardoso cardoso mentioned this pull request May 28, 2018
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants