Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Various minor QA improvements #1726

Merged
merged 10 commits into from
May 30, 2018
Merged

[FIX] Various minor QA improvements #1726

merged 10 commits into from
May 30, 2018

Conversation

cardoso
Copy link
Collaborator

@cardoso cardoso commented May 28, 2018 •
edited
Loading

@RocketChat/ios

@cardoso cardoso added this to the 3.0.0 milestone May 28, 2018
@codecov
Copy link

codecov bot commented May 28, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@0b3c309). Click here to learn what that means.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1726   +/-   ##
==========================================
  Coverage           ?   34.93%           
==========================================
  Files              ?      312           
  Lines              ?    14344           
  Branches           ?        0           
==========================================
  Hits               ?     5011           
  Misses             ?     9333           
  Partials           ?        0
Impacted Files Coverage Δ
...trollers/Subscriptions/NewRoomViewController.swift 12.82% <ø> (ø)
Rocket.Chat/API/Clients/AuthClient.swift 0% <0%> (ø)
...Auth/AuthViewControllerAuthenticationHandler.swift 0% <0%> (ø)
...et.Chat/Managers/Requests/InfoRequestHandler.swift 59.45% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3c309...28d99bf. Read the comment docs.

@cardoso cardoso changed the title [WIP][QA] Various minor QA improvements [FIX] Various minor QA improvements May 28, 2018
rafaelks
rafaelks reviewed May 30, 2018
View reviewed changes
Rocket.Chat/Resources/pt-BR.lproj/Localizable.strings Outdated
@@ -146,11 +146,10 @@
"new_room.cell.public_channel.description.public_only" = "Você só pode criar canais públicos";
"new_room.cell.public_channel.description.private_only" = "Você só pode criar canais privados";
"new_room.cell.read_only.title" = "Canal somente leitura";
"new_room.cell.read_only.description" = "Somente o admin pode escrever novas mensagens";
"new_room.cell.read_only.description" = "Apenas usuários autorizados podem enviar novas mensagens"; // TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove the // TODO here?

@rafaelks
Copy link
Contributor

@cardoso Nice one! This PR is removing the fallback compatibility for logins with WebSocket already?

@filipealva filipealva self-requested a review May 30, 2018 12:25
filipealva
filipealva approved these changes May 30, 2018
View reviewed changes
Copy link
Collaborator

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Ready to merge after solving the conflicts 👍

@cardoso
Copy link
Collaborator Author

cardoso commented May 30, 2018

@rafaelks It wasn't needed. I was just doing it if there was any error with the HTTP login, but it shouldn't happen. It's better to remove the code.

@rafaelks
Copy link
Contributor

@cardoso Got it! Just need to resolve the conflicts then 👍

@rafaelks rafaelks merged commit cb5f7f9 into develop May 30, 2018
@rafaelks rafaelks deleted the fix/qa_bugs branch May 30, 2018 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafaelks rafaelks rafaelks left review comments

@filipealva filipealva filipealva approved these changes

Assignees
No one assigned
Labels
🐛 bug 🔨 qa improvement
Projects
None yet
Milestone
3.0.0
3 participants
@cardoso @rafaelks @filipealva