[WIP] RC Xcode-11 workaround #2781

bobrenji · 2019-11-03T07:25:30Z

@RocketChat/ios

Please note this branch is still [WIP]. Please help me to review.

Issue 1: After successful login, app shows black screen
How to produce: Run on Xcode -11 [Fixed as a work around]

Issue 2: App always shows notification view on top of the screen. [Fixed as a work around]
Soln: NotificationViewController.shared.notificationViewIsHidden = true add as a work around. But not able to figure out what is the root cause.

Issue 3: SearchBar in SubscriptionsViewController shows navigation bar without background color.
once search view appears, navigation bar background color become transparent. [No solution yet]

…r error

…ile launch app - Notification window is always open when app run using Blackberry SDK. It happen for only RC wrapped with BB SDK.

- we are not using video hence I removed jitsi support for a while. once I fix all other issues, I will put it back

houndci-bot · 2019-11-03T07:25:42Z

Pods/OAuthSwift/Sources/OAuthWebViewController.swift

                    // FIXME: if we present as window, window close must detected and oauthswift.cancel() must be called...
                case .asPopover(let positioningRect, let positioningView, let preferredEdge, let behavior):
-                    p.presentViewController(self, asPopoverRelativeTo: positioningRect, of: positioningView, preferredEdge: preferredEdge, behavior: behavior)
+                    p.present(self, asPopoverRelativeTo: positioningRect, of: positioningView, preferredEdge: preferredEdge, behavior: behavior)


Line Length Violation: Line should be 120 characters or less: currently 144 characters (line_length)

houndci-bot · 2019-11-03T07:25:42Z

Pods/OAuthSwift/Sources/OAuthSwiftURLHandlerType.swift

+                                                            UIApplication.shared.open(url, options: [:], completionHandler: nil)
+                                                            return
+                                                        }
+                                                        UIApplication.shared.open(successURL, options: [:], completionHandler: nil)


Line Length Violation: Line should be 120 characters or less: currently 131 characters (line_length)

houndci-bot · 2019-11-03T07:25:42Z

Pods/OAuthSwift/Sources/OAuthSwiftURLHandlerType.swift

+                                                            let msg = error?.localizedDescription.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed)
+                                                            let urlString = "\(self.callbackUrlScheme)?error=\(msg ?? "UNKNOWN")"
+                                                            let url = URL(string: urlString)!
+                                                            UIApplication.shared.open(url, options: [:], completionHandler: nil)


Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)

houndci-bot · 2019-11-03T07:25:42Z

Pods/OAuthSwift/Sources/OAuthSwiftURLHandlerType.swift

+                                                     completionHandler: { callback, error in
+                                                        guard error == nil, let successURL = callback else {
+                                                            let msg = error?.localizedDescription.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed)
+                                                            let urlString = "\(self.callbackUrlScheme)?error=\(msg ?? "UNKNOWN")"


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2019-11-03T07:25:43Z

Pods/OAuthSwift/Sources/OAuthSwiftURLHandlerType.swift

+                                                     callbackURLScheme: callbackUrlScheme,
+                                                     completionHandler: { callback, error in
+                                                        guard error == nil, let successURL = callback else {
+                                                            let msg = error?.localizedDescription.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed)


Line Length Violation: Line should be 120 characters or less: currently 159 characters (line_length)

houndci-bot · 2019-11-03T07:25:44Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

@@ -136,6 +154,9 @@ extension OAuthSwiftError: CustomNSError {

        case .tokenExpired(let e): return ["error": e as Any]
        case .requestError(let e, let request): return ["error": e, "request": request]
+        case .authorizationPending(let e, let request): return ["error": e, "request": request]
+        case .slowDown(let e, let request): return ["error": e, "request": request]
+        case .accessDenied(let e, let request): return ["error": e, "request": request]


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:25:45Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

@@ -136,6 +154,9 @@ extension OAuthSwiftError: CustomNSError {

        case .tokenExpired(let e): return ["error": e as Any]
        case .requestError(let e, let request): return ["error": e, "request": request]
+        case .authorizationPending(let e, let request): return ["error": e, "request": request]
+        case .slowDown(let e, let request): return ["error": e, "request": request]


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:25:45Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

@@ -136,6 +154,9 @@ extension OAuthSwiftError: CustomNSError {

        case .tokenExpired(let e): return ["error": e as Any]
        case .requestError(let e, let request): return ["error": e, "request": request]
+        case .authorizationPending(let e, let request): return ["error": e, "request": request]


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:25:45Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

        }
    }

    public var underlyingError: Error? {
        switch self {
        case .tokenExpired(let e): return e
        case .requestError(let e, _): return e
+        case .authorizationPending(let e, _): return e
+        case .slowDown(let e, _): return e
+        case .accessDenied(let e, _): return e


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:25:45Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

        }
    }

    public var underlyingError: Error? {
        switch self {
        case .tokenExpired(let e): return e
        case .requestError(let e, _): return e
+        case .authorizationPending(let e, _): return e
+        case .slowDown(let e, _): return e


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:25:49Z

Rocket.Chat/Controllers/Chat/MessagesViewController.swift

@@ -633,7 +633,7 @@ extension MessagesViewController {
        return .zero
    }

-    override func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {
+    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {


Line Length Violation: Line should be 120 characters or less: currently 160 characters (line_length)

houndci-bot · 2019-11-03T07:25:50Z

Rocket.Chat/Controllers/Notification/NotificationViewController.swift

+            } else {
+                  (UIApplication.shared.value(forKey: "statusBarWindow") as? UIWindow)?.alpha = newValue || isDeviceWithNotch ? 1 : 0
+            }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:25:50Z

Rocket.Chat/Controllers/Notification/NotificationViewController.swift

+                statusBar.alpha = newValue || isDeviceWithNotch ? 1 : 0
+                   window?.addSubview(statusBar)
+            } else {
+                  (UIApplication.shared.value(forKey: "statusBarWindow") as? UIWindow)?.alpha = newValue || isDeviceWithNotch ? 1 : 0


Line Length Violation: Line should be 120 characters or less: currently 133 characters (line_length)

houndci-bot · 2019-11-03T07:25:50Z

Rocket.Chat/Controllers/Notification/NotificationViewController.swift

@@ -40,7 +40,17 @@ final class NotificationViewController: TopTransparentViewController {
        set {
            visibleConstraint?.isActive = !newValue
            hiddenConstraint?.isActive = newValue
-            (UIApplication.shared.value(forKey: "statusBarWindow") as? UIWindow)?.alpha = newValue || isDeviceWithNotch ? 1 : 0
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:25:50Z

Pods/SwipeCellKit/Source/SwipeController.swift

+        actionsContainerView.center = CGPoint(x: targetCenter, y: actionsContainerView.center.y)
+        swipeable.actionsView?.visibleWidth = abs(actionsContainerView.frame.minX)
+    }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:25:52Z

Pods/SwipeCellKit/Source/SwipeActionsView.swift

+    #if canImport(Combine)
+        if let backgroundColor = options.backgroundColor {
+            self.backgroundColor = backgroundColor
+        }


Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)

houndci-bot · 2019-11-03T07:25:52Z

Pods/SwipeCellKit/Source/SwipeActionsView.swift

@@ -111,7 +111,25 @@ class SwipeActionsView: UIView {

        clipsToBounds = true
        translatesAutoresizingMaskIntoConstraints = false
-        backgroundColor = options.backgroundColor ?? #colorLiteral(red: 0.862745098, green: 0.862745098, blue: 0.862745098, alpha: 1)
+
+


Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

houndci-bot · 2019-11-03T07:25:53Z

Pods/SwipeCellKit/Source/SwipeActionsView.swift

@@ -111,7 +111,25 @@ class SwipeActionsView: UIView {

        clipsToBounds = true
        translatesAutoresizingMaskIntoConstraints = false
-        backgroundColor = options.backgroundColor ?? #colorLiteral(red: 0.862745098, green: 0.862745098, blue: 0.862745098, alpha: 1)
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:25:53Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

-                } else if let encodedString_ = self.rawString.addingPercentEncoding(withAllowedCharacters: CharacterSet.urlQueryAllowed) {
+                if rawString.range(of: "%[0-9A-Fa-f]{2}", options: .regularExpression, range: nil, locale: nil) != nil {
+                    return Foundation.URL(string: rawString)
+                } else if let encodedString_ = rawString.addingPercentEncoding(withAllowedCharacters: CharacterSet.urlQueryAllowed) {


Identifier Name Violation: Variable name should only contain alphanumeric characters: 'encodedString_' (identifier_name)

houndci-bot · 2019-11-03T07:25:53Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

@@ -923,17 +842,15 @@ extension JSON {
 extension JSON {

    public var null: NSNull? {
+        set {


Unused Setter Value Violation: Setter value is not used. (unused_setter_value)

CLAassistant · 2019-11-03T07:26:12Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CLAassistant · 2019-11-03T07:26:14Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

houndci-bot · 2019-11-03T07:26:31Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

-            if self.type == .dictionary {
-                if let o = self.rawDictionary[key] {
+            if type == .dictionary {
+                if let o = rawDictionary[key] {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'o' (identifier_name)

houndci-bot · 2019-11-03T07:26:31Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

-        var unwrappedDic = dictionary
-        for (k, v) in dictionary {
-            unwrappedDic[k] = unwrap(v)
+        var d = dictionary


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'd' (identifier_name)

houndci-bot · 2019-11-03T07:26:32Z

Pods/SwipeCellKit/Source/SwipeActionButton.swift

@@ -35,7 +35,7 @@ class SwipeActionButton: UIButton {
    }

    override var intrinsicContentSize: CGSize {
-        return CGSize(width: UIViewNoIntrinsicMetric, height: contentEdgeInsets.top + alignmentRect.height + contentEdgeInsets.bottom)
+        return CGSize(width: UIView.noIntrinsicMetric, height: contentEdgeInsets.top + alignmentRect.height + contentEdgeInsets.bottom)


Line Length Violation: Line should be 120 characters or less: currently 135 characters (line_length)

houndci-bot · 2019-11-03T07:26:32Z

Pods/RocketChatViewController/RocketChatViewController/Classes/RocketChatViewController.swift

-        let animationCurveRawNSN = notification.userInfo?[UIKeyboardAnimationCurveUserInfoKey] as? NSNumber
-        let animationCurveRaw = animationCurveRawNSN?.uintValue ?? UIViewAnimationOptions.curveEaseInOut.rawValue
-        let animationCurve = UIViewAnimationOptions(rawValue: animationCurveRaw)
+        let animationDuration: TimeInterval = (notification.userInfo?[UIResponder.keyboardAnimationDurationUserInfoKey] as? NSNumber)?.doubleValue ?? 0


Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:32Z

Pods/RocketChatViewController/Composer/Classes/Views/ComposerView.swift

@@ -353,7 +351,7 @@ public extension ComposerView {
    /**
     Called when the content size of the text view changes and adjusts the composer height constraint.
     */
-    public override func observeValue(forKeyPath keyPath: String?, of object: Any?, change: [NSKeyValueChangeKey : Any]?, context: UnsafeMutableRawPointer?) {
+    override func observeValue(forKeyPath keyPath: String?, of object: Any?, change: [NSKeyValueChangeKey : Any]?, context: UnsafeMutableRawPointer?) {


Block Based KVO Violation: Prefer the new block based KVO API with keypaths when using Swift 3.2 or later. (block_based_kvo)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:34Z

Pods/RocketChatViewController/Composer/Classes/Addons/Reply/ReplyView.swift

@@ -133,7 +133,7 @@ public class ReplyView: UIView {
        clipsToBounds = true
        isHidden = true

-        NotificationCenter.default.addObserver(forName: .UIContentSizeCategoryDidChange, object: nil, queue: nil, using: { [weak self] _ in
+        NotificationCenter.default.addObserver(forName: UIContentSizeCategory.didChangeNotification, object: nil, queue: nil, using: { [weak self] _ in


Discarded Notification Center Observer Violation: When registering for a notification using a block, the opaque observer that is returned should be stored so it can be removed later. (discarded_notification_center_observer)
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:35Z

Rocket.Chat/Managers/OAuthManager.swift

+                failure()
+            }
+        } != nil
+//        return oauthSwift.authorize(withCallbackURL: callbackUrl, scope: scope, state: state, success: { _, _, _  in }, failure: { _ in


Line Length Violation: Line should be 120 characters or less: currently 137 characters (line_length)

houndci-bot · 2019-11-03T07:26:35Z

Rocket.Chat/Managers/OAuthManager.swift

+            switch result {
+            case .success(_, _, _): break
+//                self.showTokenAlert(name: serviceParameters["name"], credential: credential)
+            case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2019-11-03T07:26:35Z

Rocket.Chat/Managers/OAuthManager.swift

-        }) != nil
+        return oauthSwift.authorize(withCallbackURL: callbackUrl, scope: scope, state: state) { result in
+            switch result {
+            case .success(_, _, _): break


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2019-11-03T07:26:35Z

Rocket.Chat/Extensions/UISearchBar/UISearchBarTextField.swift

+        } else {
+            return value(forKey: "_searchField") as? UITextField
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:26:37Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

-            if self.type == .dictionary {
-                if let o = self.rawDictionary[key] {
+            if type == .dictionary {
+                if let o = rawDictionary[key] {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'o' (identifier_name)

houndci-bot · 2019-11-03T07:26:37Z

Pods/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift

-        var unwrappedDic = dictionary
-        for (k, v) in dictionary {
-            unwrappedDic[k] = unwrap(v)
+        var d = dictionary


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'd' (identifier_name)

houndci-bot · 2019-11-03T07:26:37Z

Pods/SwipeCellKit/Source/SwipeActionButton.swift

@@ -35,7 +35,7 @@ class SwipeActionButton: UIButton {
    }

    override var intrinsicContentSize: CGSize {
-        return CGSize(width: UIViewNoIntrinsicMetric, height: contentEdgeInsets.top + alignmentRect.height + contentEdgeInsets.bottom)
+        return CGSize(width: UIView.noIntrinsicMetric, height: contentEdgeInsets.top + alignmentRect.height + contentEdgeInsets.bottom)


Line Length Violation: Line should be 120 characters or less: currently 135 characters (line_length)

houndci-bot · 2019-11-03T07:26:37Z

Pods/RocketChatViewController/RocketChatViewController/Classes/RocketChatViewController.swift

-        let animationCurveRawNSN = notification.userInfo?[UIKeyboardAnimationCurveUserInfoKey] as? NSNumber
-        let animationCurveRaw = animationCurveRawNSN?.uintValue ?? UIViewAnimationOptions.curveEaseInOut.rawValue
-        let animationCurve = UIViewAnimationOptions(rawValue: animationCurveRaw)
+        let animationDuration: TimeInterval = (notification.userInfo?[UIResponder.keyboardAnimationDurationUserInfoKey] as? NSNumber)?.doubleValue ?? 0


Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:38Z

Pods/RocketChatViewController/Composer/Classes/Views/ComposerView.swift

@@ -353,7 +351,7 @@ public extension ComposerView {
    /**
     Called when the content size of the text view changes and adjusts the composer height constraint.
     */
-    public override func observeValue(forKeyPath keyPath: String?, of object: Any?, change: [NSKeyValueChangeKey : Any]?, context: UnsafeMutableRawPointer?) {
+    override func observeValue(forKeyPath keyPath: String?, of object: Any?, change: [NSKeyValueChangeKey : Any]?, context: UnsafeMutableRawPointer?) {


Block Based KVO Violation: Prefer the new block based KVO API with keypaths when using Swift 3.2 or later. (block_based_kvo)
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:39Z

Pods/RocketChatViewController/Composer/Classes/Addons/Reply/ReplyView.swift

@@ -133,7 +133,7 @@ public class ReplyView: UIView {
        clipsToBounds = true
        isHidden = true

-        NotificationCenter.default.addObserver(forName: .UIContentSizeCategoryDidChange, object: nil, queue: nil, using: { [weak self] _ in
+        NotificationCenter.default.addObserver(forName: UIContentSizeCategory.didChangeNotification, object: nil, queue: nil, using: { [weak self] _ in


Discarded Notification Center Observer Violation: When registering for a notification using a block, the opaque observer that is returned should be stored so it can be removed later. (discarded_notification_center_observer)
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:26:39Z

Rocket.Chat/Managers/OAuthManager.swift

+                failure()
+            }
+        } != nil
+//        return oauthSwift.authorize(withCallbackURL: callbackUrl, scope: scope, state: state, success: { _, _, _  in }, failure: { _ in


Line Length Violation: Line should be 120 characters or less: currently 137 characters (line_length)

houndci-bot · 2019-11-03T07:26:40Z

Rocket.Chat/Managers/OAuthManager.swift

+            switch result {
+            case .success(_, _, _): break
+//                self.showTokenAlert(name: serviceParameters["name"], credential: credential)
+            case .failure(_):


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2019-11-03T07:26:40Z

Rocket.Chat/Managers/OAuthManager.swift

-        }) != nil
+        return oauthSwift.authorize(withCallbackURL: callbackUrl, scope: scope, state: state) { result in
+            switch result {
+            case .success(_, _, _): break


Empty Enum Arguments Violation: Arguments can be omitted when matching enums with associated types if they are not used. (empty_enum_arguments)

houndci-bot · 2019-11-03T07:26:40Z

Rocket.Chat/Extensions/UISearchBar/UISearchBarTextField.swift

+        } else {
+            return value(forKey: "_searchField") as? UITextField
+        }
+


Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

houndci-bot · 2019-11-03T07:27:26Z

Rocket.Chat/Controllers/Threads/ThreadsViewController.swift

@@ -158,7 +158,7 @@ extension ThreadsViewController {
        return .zero
    }

-    override func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {
+    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {


Line Length Violation: Line should be 120 characters or less: currently 160 characters (line_length)

houndci-bot · 2019-11-03T07:27:27Z

Pods/RocketChatViewController/Composer/Classes/Addons/Hints/HintsView.swift

@@ -101,14 +101,14 @@ public class HintsView: UITableView {
     Shared initialization procedures.
     */
    private func commonInit() {
-        NotificationCenter.default.addObserver(forName: .UIContentSizeCategoryDidChange, object: nil, queue: nil, using: { [weak self] _ in
+        NotificationCenter.default.addObserver(forName: UserDefaults.didChangeNotification, object: nil, queue: nil, using: { [weak self] _ in


Discarded Notification Center Observer Violation: When registering for a notification using a block, the opaque observer that is returned should be stored so it can be removed later. (discarded_notification_center_observer)
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)

houndci-bot · 2019-11-03T07:27:27Z

Pods/RocketChatViewController/Composer/Classes/Addons/Editing/EditingView.swift

@@ -83,7 +83,7 @@ public class EditingView: UIView, ComposerLocalizable {
        clipsToBounds = true
        isHidden = true

-        NotificationCenter.default.addObserver(forName: .UIContentSizeCategoryDidChange, object: nil, queue: nil, using: { [weak self] _ in
+        NotificationCenter.default.addObserver(forName: UIContentSizeCategory.didChangeNotification, object: nil, queue: nil, using: { [weak self] _ in


Discarded Notification Center Observer Violation: When registering for a notification using a block, the opaque observer that is returned should be stored so it can be removed later. (discarded_notification_center_observer)
Line Length Violation: Line should be 120 characters or less: currently 151 characters (line_length)

houndci-bot · 2019-11-03T07:27:27Z

Pods/RealmSwift/RealmSwift/Util.swift

@@ -93,7 +94,8 @@ internal func dynamicBridgeCast<T>(fromObjectiveC x: Any) -> T {
    }
 }

-internal func dynamicBridgeCast<T>(fromSwift x: T) -> Any {
+/// :nodoc:
+public func dynamicBridgeCast<T>(fromSwift x: T) -> Any {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'x' (identifier_name)

houndci-bot · 2019-11-03T07:27:27Z

Pods/RealmSwift/RealmSwift/Util.swift

@@ -83,7 +83,8 @@ extension Object {

 // MARK: CustomObjectiveCBridgeable

-internal func dynamicBridgeCast<T>(fromObjectiveC x: Any) -> T {
+/// :nodoc:
+public func dynamicBridgeCast<T>(fromObjectiveC x: Any) -> T {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'x' (identifier_name)

houndci-bot · 2019-11-03T07:27:29Z

Pods/RealmSwift/RealmSwift/Realm.swift

@@ -387,11 +569,56 @@ public final class Realm {
     :nodoc:
     */
    @discardableResult
-    public func dynamicCreate(_ typeName: String, value: Any = [:], update: Bool = false) -> DynamicObject {
-        if update && schema[typeName]?.primaryKeyProperty == nil {
+    @available(*, deprecated, message: "Pass .error, .modified or .all rather than a boolean. .error is equivalent to false and .all is equivalent to true.")


Line Length Violation: Line should be 120 characters or less: currently 157 characters (line_length)

houndci-bot · 2019-11-03T07:27:30Z

Pods/RealmSwift/RealmSwift/Realm.swift

-        return unsafeDowncast(RLMCreateObjectInRealmWithValue(rlmRealm, typeName, value, update), to: T.self)
+        let typeName = (type as Object.Type).className()
+        return unsafeDowncast(RLMCreateObjectInRealmWithValue(rlmRealm, typeName, value,
+                                                              RLMUpdatePolicy(rawValue: UInt(update.rawValue))!), to: type)


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-11-03T07:27:30Z

Pods/RealmSwift/RealmSwift/Realm.swift

-        let typeName = (type as Object.Type).className()
-        if update && schema[typeName]?.primaryKeyProperty == nil {
-            throwRealmException("'\(typeName)' does not have a primary key and can not be updated")
+    @available(*, deprecated, message: "Pass .error, .modified or .all rather than a boolean. .error is equivalent to false and .all is equivalent to true.")


Line Length Violation: Line should be 120 characters or less: currently 157 characters (line_length)

houndci-bot · 2019-11-03T07:27:30Z

Pods/RealmSwift/RealmSwift/Realm.swift

@@ -297,7 +422,27 @@ public final class Realm {
     - parameter objects: A sequence which contains objects to be added to the Realm.
     - parameter update: If `true`, objects that are already in the Realm will be updated instead of added anew.
     */
-    public func add<S: Sequence>(_ objects: S, update: Bool = false) where S.Iterator.Element: Object {
+    @available(*, deprecated, message: "Pass .error, .modified or .all rather than a boolean. .error is equivalent to false and .all is equivalent to true.")


Line Length Violation: Line should be 120 characters or less: currently 157 characters (line_length)

houndci-bot · 2019-11-03T07:27:31Z

Pods/RealmSwift/RealmSwift/Realm.swift


     - parameter object: The object to be added to this Realm.
     - parameter update: If `true`, the Realm will try to find an existing copy of the object (with the same primary
                         key), and update it. Otherwise, the object will be added.
     */
-    public func add(_ object: Object, update: Bool = false) {
-        if update && object.objectSchema.primaryKeyProperty == nil {
+    @available(*, deprecated, message: "Pass .error, .modified or .all rather than a boolean. .error is equivalent to false and .all is equivalent to true.")


Line Length Violation: Line should be 120 characters or less: currently 157 characters (line_length)

houndci-bot · 2019-11-03T07:27:50Z

Pods/RealmSwift/RealmSwift/Realm.swift

-                                 callback: @escaping (Realm?, Swift.Error?) -> Void) {
-        RLMRealm.asyncOpen(with: configuration.rlmConfiguration, callbackQueue: callbackQueue) { rlmRealm, error in
+                                 callback: @escaping (Realm?, Swift.Error?) -> Void) -> AsyncOpenTask {
+        return AsyncOpenTask(rlmTask: RLMRealm.asyncOpen(with: configuration.rlmConfiguration, callbackQueue: callbackQueue) { rlmRealm, error in


Line Length Violation: Line should be 120 characters or less: currently 145 characters (line_length)

houndci-bot · 2019-11-03T07:27:51Z

Pods/RealmSwift/RealmSwift/ObjectSchema.swift

@@ -18,6 +18,7 @@

 import Foundation
 import Realm
+import Realm.Private


Duplicate Imports Violation: Imports should be unique. (duplicate_imports)

houndci-bot · 2019-11-03T07:27:51Z

Pods/RealmSwift/RealmSwift/Object.swift

@@ -456,6 +475,11 @@ public class ObjectUtil: NSObject {
                    // Ignored lazy property.
                    return false
                }
+                if object is RLMObject {
+                    // Implicitly ignore lazy properties on RLMObject subclasses
+                    // FIXME: should align RLMObject/Object behavior in 4.0


Todo Violation: FIXMEs should be resolved (should align RLMObject/Object ...). (todo)

houndci-bot · 2019-11-03T07:27:51Z

Pods/ReachabilitySwift/Sources/Reachability.swift

+        let C = isConnectionOnTrafficFlagSet ? "C" : "-"
+        let D = isConnectionOnDemandFlagSet ? "D" : "-"
+        let l = isLocalAddressFlagSet ? "l" : "-"
+        let d = isDirectFlagSet ? "d" : "-"


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'd' (identifier_name)

houndci-bot · 2019-11-03T07:27:52Z

Pods/ReachabilitySwift/Sources/Reachability.swift

+        let i = isInterventionRequiredFlagSet ? "i" : "-"
+        let C = isConnectionOnTrafficFlagSet ? "C" : "-"
+        let D = isConnectionOnDemandFlagSet ? "D" : "-"
+        let l = isLocalAddressFlagSet ? "l" : "-"


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'l' (identifier_name)

houndci-bot · 2019-11-03T07:27:53Z

Pods/ReachabilitySwift/Sources/Reachability.swift

@@ -313,4 +348,59 @@ extension SCNetworkReachabilityFlags {
    var isConnectionRequiredAndTransientFlagSet: Bool {
        return intersection([.connectionRequired, .transientConnection]) == [.connectionRequired, .transientConnection]
    }
+
+    var description: String {
+        let W = isOnWWANFlagSet ? "W" : "-"


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'W' (identifier_name)

houndci-bot · 2019-11-03T07:27:54Z

Pods/ReachabilitySwift/Sources/Reachability.swift

-        var context = SCNetworkReachabilityContext(version: 0, info: nil, retain: nil, release: nil, copyDescription: nil)
-        context.info = UnsafeMutableRawPointer(Unmanaged<Reachability>.passUnretained(self).toOpaque())
+        let weakifiedReachability = ReachabilityWeakifier(reachability: self)
+        let opaqueWeakifiedReachability = Unmanaged<ReachabilityWeakifier>.passUnretained(weakifiedReachability).toOpaque()


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-11-03T07:27:54Z

Pods/ReachabilitySwift/Sources/Reachability.swift


-        self.init(reachabilityRef: ref, queueQoS: queueQoS, targetQueue: targetQueue)
+        self.init(reachabilityRef: ref, queueQoS: queueQoS, targetQueue: targetQueue, notificationQueue: notificationQueue)


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-11-03T07:27:54Z

Pods/ReachabilitySwift/Sources/Reachability.swift

+        guard let ref = SCNetworkReachabilityCreateWithName(nil, hostname) else {
+            throw ReachabilityError.failedToCreateWithHostname(hostname, SCError())
+        }
+        self.init(reachabilityRef: ref, queueQoS: queueQoS, targetQueue: targetQueue, notificationQueue: notificationQueue)


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-11-03T07:27:54Z

Pods/RCMarkdownParser/Pod/Classes/RCMarkdownParser.swift

@@ -391,3 +391,4 @@ open class RCMarkdownParser: RCBaseParser {
        return "\(char)"
    }
 }
+


Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)

…ode 11

houndci-bot · 2019-11-03T07:34:03Z

Rocket.Chat/Extensions/UIWindowExtensions.swift

+        if #available(iOS 13.0, *) {
+
+        } else {
+            /// The presenting view controllers view doesn't get removed from the window as its currently transistioning and presenting a view controller


Line Length Violation: Line should be 120 characters or less: currently 153 characters (line_length)

houndci-bot · 2019-11-03T07:34:04Z

Pods/RCMarkdownParser/Pod/Classes/RCBaseParser.swift

@@ -51,3 +51,4 @@ open class RCBaseParser {
    }

 }
+


Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)

houndci-bot · 2019-11-03T07:34:05Z

Pods/RCMarkdownParser/Pod/Classes/NSAttributedString+Markdown.swift

@@ -144,3 +144,4 @@ public extension NSAttributedString {
    }

 }
+


Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)

houndci-bot · 2019-11-03T07:34:05Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

        }
    }

    public var underlyingError: Error? {
        switch self {
        case .tokenExpired(let e): return e
        case .requestError(let e, _): return e
+        case .authorizationPending(let e, _): return e


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'e' (identifier_name)

houndci-bot · 2019-11-03T07:34:05Z

Pods/OAuthSwift/Sources/OAuthSwiftError.swift

+    case requestError(error: Error, request: URLRequest)
+    /// The provided token is expired, retrieve new token by using the refresh token
+    case tokenExpired(error: Error?)
+    /// If the user has not either allowed or denied the request yet, the authorization server will return the authorization_pending error.


Line Length Violation: Line should be 120 characters or less: currently 139 characters (line_length)

houndci-bot · 2019-11-03T07:34:07Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

-    open func makeRequest(_ urlString: String, method: OAuthSwiftHTTPRequest.Method, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil) -> OAuthSwiftHTTPRequest? {
-        guard let url = URL(string: urlString) else {
-            return nil
+    open func makeRequest(_ url: URLConvertible, method: OAuthSwiftHTTPRequest.Method, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil) -> OAuthSwiftHTTPRequest? {


Line Length Violation: Line should be 120 characters or less: currently 210 characters (line_length)

houndci-bot · 2019-11-03T07:34:07Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

    }

    @discardableResult
-    open func request(_ urlString: String, method: OAuthSwiftHTTPRequest.Method, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, checkTokenExpiration: Bool = true, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
+    open func request(_ url: URLConvertible, method: OAuthSwiftHTTPRequest.Method, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, checkTokenExpiration: Bool = true, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {


Line Length Violation: Line should be 120 characters or less: currently 315 characters (line_length)

houndci-bot · 2019-11-03T07:34:07Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

-    open func patch(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .PATCH, parameters: parameters, headers: headers, success: success, failure: failure)
+    open func patch(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {
+        return self.request(url, method: .PATCH, parameters: parameters, headers: headers, completionHandler: completion)


Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)

houndci-bot · 2019-11-03T07:34:07Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

    }

    @discardableResult
-    open func patch(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .PATCH, parameters: parameters, headers: headers, success: success, failure: failure)
+    open func patch(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {


Line Length Violation: Line should be 120 characters or less: currently 221 characters (line_length)

houndci-bot · 2019-11-03T07:34:08Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

-    open func delete(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .DELETE, parameters: parameters, headers: headers, success: success, failure: failure)
+    open func delete(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {
+        return self.request(url, method: .DELETE, parameters: parameters, headers: headers, completionHandler: completion)


Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)

houndci-bot · 2019-11-03T07:34:33Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

    }

    @discardableResult
-    open func delete(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .DELETE, parameters: parameters, headers: headers, success: success, failure: failure)
+    open func delete(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {


Line Length Violation: Line should be 120 characters or less: currently 222 characters (line_length)

houndci-bot · 2019-11-03T07:34:33Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

-    open func put(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .PUT, parameters: parameters, headers: headers, body: body, success: success, failure: failure)
+    open func put(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {
+        return self.request(url, method: .PUT, parameters: parameters, headers: headers, body: body, completionHandler: completion)


Line Length Violation: Line should be 120 characters or less: currently 131 characters (line_length)

houndci-bot · 2019-11-03T07:34:34Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

    }

    @discardableResult
-    open func put(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .PUT, parameters: parameters, headers: headers, body: body, success: success, failure: failure)
+    open func put(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {


Line Length Violation: Line should be 120 characters or less: currently 238 characters (line_length)

houndci-bot · 2019-11-03T07:34:34Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

-    open func post(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .POST, parameters: parameters, headers: headers, body: body, success: success, failure: failure)
+    open func post(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {
+        return self.request(url, method: .POST, parameters: parameters, headers: headers, body: body, completionHandler: completion)


Line Length Violation: Line should be 120 characters or less: currently 132 characters (line_length)

houndci-bot · 2019-11-03T07:34:34Z

Pods/OAuthSwift/Sources/OAuthSwiftClient.swift

    }

    @discardableResult
-    open func post(_ urlString: String, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, success: OAuthSwiftHTTPRequest.SuccessHandler?, failure: OAuthSwiftHTTPRequest.FailureHandler?) -> OAuthSwiftRequestHandle? {
-        return self.request(urlString, method: .POST, parameters: parameters, headers: headers, body: body, success: success, failure: failure)
+    open func post(_ url: URLConvertible, parameters: OAuthSwift.Parameters = [:], headers: OAuthSwift.Headers? = nil, body: Data? = nil, completionHandler completion: OAuthSwiftHTTPRequest.CompletionHandler?) -> OAuthSwiftRequestHandle? {


Line Length Violation: Line should be 120 characters or less: currently 239 characters (line_length)

houndci-bot · 2019-11-03T07:34:36Z