This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 438
[WIP] RC Xcode-11 workaround #2781
Open
bobrenji
wants to merge
9
commits into
RocketChat:develop
Choose a base branch
from
bobrenji:rc-xcode-11-wip
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
67e224b
[Renji] [WIP] Pod dependency file changes for fixing Xcode-11 compile…
bobrenji 542ff1c
[Renji] [WIP] Temp or hack for fixing the notification window hide wh…
bobrenji bd34e37
[Renji] [WIP] Removed Jitsi from app
bobrenji e29c722
[Renji] [WIP] xcode project file dependency
bobrenji cc9da85
[Renji] [WIP] Crash fix
bobrenji 97050a2
[Renji] [WIP] Compiler error
bobrenji 95e26cc
[Renji] [WIP] compiler error fix
bobrenji 4b5c727
[Renji] [WIP] compiler error fix
bobrenji 90383bf
[Renji] [WIP] Temp or hack for fixing the black screen on iOS 13 + xc…
bobrenji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ def ui_pods | |
end | ||
|
||
def diff_pods | ||
pod 'DifferenceKit', '~> 1.0' | ||
pod 'DifferenceKit/Core', '~> 1.1.3' | ||
end | ||
|
||
def shared_pods | ||
|
@@ -32,17 +32,17 @@ def shared_pods | |
pod 'RocketChatViewController', :git => 'https://github.com/RocketChat/RocketChatViewController' | ||
pod 'MobilePlayer', :git => 'https://github.com/RocketChat/RCiOSMobilePlayer' | ||
pod 'SimpleImageViewer', :git => 'https://github.com/cardoso/SimpleImageViewer.git' | ||
pod 'SwipeCellKit' | ||
pod 'SwipeCellKit', '~> 2.7.1' | ||
ui_pods | ||
|
||
# Text Processing | ||
pod 'RCMarkdownParser', :git => 'https://github.com/RocketChat/RCMarkdownParser.git' | ||
pod "RCMarkdownParser" | ||
|
||
# Database | ||
database_pods | ||
|
||
# Network | ||
pod 'Nuke', '~> 7.6' | ||
pod 'Nuke', '~> 7.3' | ||
pod 'Nuke-FLAnimatedImage-Plugin' | ||
pod 'Starscream', '~> 3' | ||
pod 'ReachabilitySwift' | ||
|
@@ -72,7 +72,8 @@ target 'Rocket.ChatTests' do | |
end | ||
|
||
post_install do |installer| | ||
swift42Targets = ['RCMarkdownParser', 'MobilePlayer'] | ||
# swift3Targets = ['MobilePlayer', 'RCMarkdownParser'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 2). |
||
swift42Targets = ['SwipeCellKit', 'MobilePlayer', 'RCMarkdownParser'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Naming/VariableName: Use snake_case for variable names. |
||
|
||
installer.pods_project.targets.each do |target| | ||
target.build_configurations.each do |config| | ||
|
@@ -85,6 +86,13 @@ post_install do |installer| | |
config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Owholemodule' | ||
end | ||
end | ||
|
||
# if swift3Targets.include? target.name | ||
# target.build_configurations.each do |config| | ||
# config.build_settings['SWIFT_VERSION'] = '3.1' | ||
# end | ||
# end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 4). |
||
|
||
if swift42Targets.include? target.name | ||
target.build_configurations.each do |config| | ||
config.build_settings['SWIFT_VERSION'] = '4.2' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.