-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jitsi-token-moderation-plugin #17563
Comments
Yup if you wanted to do this properly take a look at the code that generates the jwt. Then if user has a role of owner/moderator of channel or admin could add that property in. PRs certainly welcome! |
Hi, I don’t know if this topic will help you? I have been asking a question about the moderator here for a long time: https://community.jitsi.org/t/how-to-make-a-single-moderator/15332 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please don't close that issue. |
Maybe this could be made more generic to do mapping of role and such to token. Something customizable enough to fit multiple cases. Especially since this particular solution proposed isn’t the only way you could do it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please don't close that issue. |
@ankar84, @alonelion1987 Having only the first user be the moderator can be configured on the Jitsi side. Have a look in the prosody configuration. There are modules loaded from a plugin directory and one module is "muc_allowners". In that case, you don't want this. The lua plugins allows to configure rooms based on the token information. This is how usernames and the like and even the avatar is fetched. jitsi-token-moderation-plugin uses a flag, but to allow more flexible handling it would be better to include the user roles as well. This allows to configure the jitsi room very flexible. I will have a look at the related code, to see if a pull request is easy to do. |
@geekgonecrazy a patch adding the field looks trivial. Is adding roles and the isModerator flag acceptable as default behaviour, or does this need to be configured. |
It's not quite true for secure domain (when using JWT tokens for authentications). So, a little enhancements are needed in RC to support jitsi-token-moderation-plugin |
I think with new Jitsi version 2.0.5765 (21-04-15) that feature implemented from Jitsi side. |
Solved that issue on Jitsi side with |
Jitsi integration in Rocket.Chat with JWT authorization works very good!
But we need that only first user in call (actually user who creates the room) is granted moderator rights.
But with JWT authorization enabled in Jitsi all JWT authenticated users gets moderator permissions.
There is a nice jitsi-token-moderation-plugin lua module that can help.
All we need is first user who start the call use URL with moderator:true encrypted in JWT token and channel blue button Click to Join should open regular URL with JWT token without moderator in it.
@alonelion1987 Roman, can it be done?
@geekgonecrazy Aaron, can you take a look?
PS I also opened issue in Jitsi, but RC implementation could be more elegant, IMHO.
The text was updated successfully, but these errors were encountered: