Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add user roles to Jitsi token #20388

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

laliluna
Copy link

@laliluna laliluna commented Jan 25, 2021

Proposed changes (including videos or screenshots)

Adding the user roles to the token allows Jitsi prosody plugins like https://github.com/nvonahsen/jitsi-token-moderation-plugin/issues to determine the user role in a Jitsi conference. Though this plugin uses a different field in the token, IMHO adding the roles to the user object fits RocketChat structure better.

Issue(s)

Fixes #17563

Steps to test or reproduce

  • Enable jitsi conference with token authentication to a non existing URL of a video server
  • use a dummy ID and secret
  • once the conference link is opened, copy the token to jwt.io
  • it should include the roles or at least an empty array

Further comments

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add support for jitsi-token-moderation-plugin
5 participants