Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add user roles to Jitsi token #20382

Closed
wants to merge 1 commit into from

Conversation

laliluna
Copy link

Proposed changes (including videos or screenshots)

Adding the user roles to the token allows Jitsi prosody plugins like https://github.com/nvonahsen/jitsi-token-moderation-plugin/issues to determine the user role in a Jitsi conference. Though this plugin uses a different field in the token, IMHO adding the roles to the user object fits RocketChat structure better.

Issue(s)

#17563

Steps to test or reproduce

  • Enable jitsi conference with token authentication to a non existing URL of a video server
  • use a dummy ID and secret
  • once the conference link is opened, copy the token to jwt.io
  • it should include the roles or at least an empty array

Further comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sebastian Hennebrueder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@laliluna laliluna closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants