[PWA] Add Service worker and ownUser Cache #17269
Open
+306
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2020
Improve SW Logic DOn't refetch fonts
fix lint issues Use localforage in SW and add localforage.min.js
rodrigok
reviewed
Aug 7, 2020
| // Notifications.streamUser.__emit(data._id, clientAction, data); | ||
| Notifications.notifyUserInThisInstance( | ||
| id, | ||
| 'ownUser-changed', |
There was a problem hiding this comment.
This seems to be a security issue, anyone can subscribe to any user id and receives private data.
There was a problem hiding this comment.
Should stream to a particular user be used rather than notifying all users subscribed to it?
There was a problem hiding this comment.
Changed it to stream to a particular user only
Modified own user emit mechanism
|
We are getting ready to merge this one. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to integrate PWA functionality in RC.
https://github.com/WideChat/Rocket.Chat/wiki/PWA-features
First PR: #17269
Second PR: #17367
Third PR: #17441
Fourth PR: #17493