-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] SAML quality improvements and new config options #17742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ther service provider options
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…tag and to use the request ID; Added a migration with the old template so that existing instances will continue generating the same XML it does today.
This pull request fixes 1 alert when merging 3059ff9 into 12c11f2 - view on LGTM.com fixed alerts:
|
…ultiple contexts.
This pull request fixes 1 alert when merging 9c42820 into 12c11f2 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 2e276d0 into 1b10d80 - view on LGTM.com fixed alerts:
|
sampaiodiego
approved these changes
Jun 19, 2020
Merged
rodrigok
changed the title
[IMPROVE] SAML implementation
[NEW] SAML quality improvements and new config options
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
Some bugs were fixed with those changes:
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments