Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] SAML quality improvements and new config options #17742

Merged
merged 73 commits into from
Jun 19, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented May 25, 2020

Proposed changes

Issue(s)

Some bugs were fixed with those changes:

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

  • Code quality improvements adding tests and converting to TypeScript
  • Add new settings to manually configure the Request, Response and Metadata XMLs
  • New setting to configure the identifier format
  • Expands the user fieldset setting with new functionality
  • Adds the possibility of choosing a custom identifier other than name and email

Further comments

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

…tag and to use the request ID;

Added a migration with the old template so that existing instances will continue generating the same XML it does today.
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2020

This pull request fixes 1 alert when merging 3059ff9 into 12c11f2 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2020

This pull request fixes 1 alert when merging 9c42820 into 12c11f2 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 19, 2020

This pull request fixes 1 alert when merging 2e276d0 into 1b10d80 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

@sampaiodiego sampaiodiego changed the title SAML Unit Tests [IMPROVE] SAML implementation Jun 19, 2020
@sampaiodiego sampaiodiego merged commit ee85880 into develop Jun 19, 2020
@sampaiodiego sampaiodiego deleted the advanced-saml branch June 19, 2020 20:51
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
@rodrigok rodrigok changed the title [IMPROVE] SAML implementation [NEW] SAML quality improvements and new config options Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants