Fix SAML logout response issues #17879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<samlp:StatusCode/> must be enclosed in <samlp:Status/>
|
|
<samlp:LogoutResponse/> must contain the InResponseTo= attribute which contains the value from the <samlp:LogoutRequest>
|
I don't know why |
|
PR #17742 will change the generation of the XML to allow editing a template, with it you'll be able to include the tag on the response. I'll merge this into that PR to include the |
18 tasks
|
Closing via #17742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML logout is currently broken in 2 ways:
<samlp:LogoutResponse>which doesn't enclose<samlp:StatusCode/>into<samlp:Status/>InResponseTo="$IDofRequest"attribute in the<samlp:LogoutResponse>which must be filled with theIDattribute from the<samlp:LogoutRequest>.