Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Apps room events losing data #17827

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[FIX] Apps room events losing data #17827

merged 1 commit into from
Jun 9, 2020

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 4, 2020 •
edited
Loading

Proposed changes

Add a new field in the rooms converter.

Without this addition, information is lost between the execution of the IPreRoomCreateExtend and IPreRoomCreateModify events.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@d-gubert d-gubert requested a review from rodrigok June 5, 2020 16:08
@d-gubert d-gubert added this to the 3.3.1 milestone Jun 5, 2020
@sampaiodiego sampaiodiego changed the title [FIX] Add new fields to the room converter [FIX] Apps room events losing data Jun 9, 2020
@sampaiodiego sampaiodiego merged commit 31bf5e3 into develop Jun 9, 2020
@sampaiodiego sampaiodiego deleted the apps/fix-room-converter branch June 9, 2020 19:13
@sampaiodiego sampaiodiego mentioned this pull request Jun 10, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Jun 10, 2020
@d-gubert @sampaiodiego
[FIX] Apps room events losing data (#17827)
ae28107
ggazzo added a commit that referenced this pull request Jun 10, 2020
@ggazzo
Merge branch 'feat/new-threads' of github.com:RocketChat/Rocket.Chat …
01d47a9 
…into feat/new-threads

* 'feat/new-threads' of github.com:RocketChat/Rocket.Chat:
  [FIX] Reorder hljs (#17854)
  [FIX] SAML LogoutRequest sending wrong NameID (#17860)
  [FIX] Apps room events losing data (#17827)
ggazzo added a commit that referenced this pull request Jun 17, 2020
@ggazzo
Merge branch 'threads-alpha' of github.com:RocketChat/Rocket.Chat int…
6693157 
…o threads-alpha

* 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839)
  [FIX] Undesirable message updates after user saving profile (#17930)
  Remove unused accounts-js integration (#17921)
  [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907)
  [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669)
  correct outdated dev start info
  [IMPROVE] Rewrite Federation Dashboard (#17900)
  [FIX] Duplicated placeholderaceholder  (#17898)
  Wrap components with React.memo (#17899)
  [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808)
  Change some components' location (#17893)
  [IMPROVE] Rewrite admin sidebar in React (#17801)
  Always initialize CIRCLE_BRANCH env var on CI (#17874)
  [NEW] Blocked Media Types setting (#17617)
  [FIX] Reorder hljs (#17854)
  [FIX] SAML LogoutRequest sending wrong NameID (#17860)
  [FIX] Apps room events losing data (#17827)
  [FIX] Importers progress sending too much update events to clients (#17857)
  [FIX] Omnichannel message link is broken in email notifications (#17843)
  [FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@d-gubert @sampaiodiego