[FIX] Importers progress sending too much update events to clients #17857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwhelm the connection
|
I believe 50ms is a short period 🤷 , maybe something around 150~250? |
sampaiodiego
requested changes
Jun 9, 2020
There was a problem hiding this comment.
I agree with @ggazzo .. sending 4 updates per second (250ms delay) I think is enough
sampaiodiego
approved these changes
Jun 9, 2020
sampaiodiego
changed the title
ggazzo
added a commit
that referenced
this pull request
Jun 9, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) Refactor components and views to Storybook compatibility (#17800) [FIX] Slack importer settings object (#17776) Create codeql-analysis.yml
ggazzo
added a commit
that referenced
this pull request
Jun 17, 2020
…o threads-alpha * 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits) [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839) [FIX] Undesirable message updates after user saving profile (#17930) Remove unused accounts-js integration (#17921) [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907) [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669) correct outdated dev start info [IMPROVE] Rewrite Federation Dashboard (#17900) [FIX] Duplicated placeholderaceholder (#17898) Wrap components with React.memo (#17899) [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808) Change some components' location (#17893) [IMPROVE] Rewrite admin sidebar in React (#17801) Always initialize CIRCLE_BRANCH env var on CI (#17874) [NEW] Blocked Media Types setting (#17617) [FIX] Reorder hljs (#17854) [FIX] SAML LogoutRequest sending wrong NameID (#17860) [FIX] Apps room events losing data (#17827) [FIX] Importers progress sending too much update events to clients (#17857) [FIX] Omnichannel message link is broken in email notifications (#17843) [FIX] Logic for room type was inverted in edit panel (#17851) (#17853) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When importing a file, the server would send a new socket message to the client after every imported message. Sometimes when importing a large file this could overwhelm the web socket and cause the progress bar to fall behind. This PR changes the server to only send one update every 50ms.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments