Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings #22978

Merged
merged 8 commits into from
Sep 9, 2021
Merged

[FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings #22978

merged 8 commits into from
Sep 9, 2021

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Aug 19, 2021 •
edited by ostjen
Loading

Proposed changes (including videos or screenshots)

  • Fix inaccurate use of 'Mobile notifications' (which is misleading in German) by 'Push notifications';
  • Update 'Notification_Mobile_Default_For' key to 'Notification_Push_Default_For' (and text to 'Send Push Notifications For' for English Language);
  • Update 'Accounts_Default_User_Preferences_mobileNotifications' key to 'Accounts_Default_User_Preferences_pushNotifications';
  • Update 'Mobile_Notifications_Default_Alert' key to 'Mobile_Push_Notifications_Default_Alert';

Issue(s)

Steps to test or reproduce

  1. Click on your profile photo > Preferences > Notifications and check the 'Send Push Notifications For' field (the label was 'Push Mobile Notifications For');
  2. Check the "Non-registered server" banner (in German, the message should contain the text 'Push-Benachrichtigungen' instead of 'Mobile Benachrichtigungen').

Further comments

@ostjen ostjen self-requested a review August 26, 2021 20:12
@matheusbsilva137 matheusbsilva137 merged commit fad5585 into develop Sep 9, 2021
@matheusbsilva137 matheusbsilva137 deleted the fix/i18n-push-notifications branch September 9, 2021 00:00
gabriellsh added a commit that referenced this pull request Sep 9, 2021
@gabriellsh
Merge branch 'feat/seats-cap-request-seats' of github.com:RocketChat/…
2a61440 
…Rocket.Chat into feat/seats-cap-request-seats

* 'feat/seats-cap-request-seats' of github.com:RocketChat/Rocket.Chat: (59 commits)
  Chore: client endpoints typings (#23152)
  Chore: Update pino and pino-pretty (#23157)
  Bump @rocket.chat/string-helpers in /ee/server/services (#23138)
  [FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings (#22978)
  Bump xml-crypto from 2.1.2 to 2.1.3 (#23141)
  [IMPROVE] Change log format to JSON (#22975)
  Regression: Auth banner for EE (#23091)
  [IMPROVE][APPS] Return task ids when using the scheduler api (#23023)
  [FIX] Update bugsnag package (#23104)
  Bump pm2 from 5.1.0 to 5.1.1 in /ee/server/services (#23128)
  Bump @types/ejson from 2.1.2 to 2.1.3 in /ee/server/services (#23126)
  Chore: Remove non-used dependencies (#23109)
  Bump @types/ws from 7.4.6 to 7.4.7 in /ee/server/services (#23095)
  Bump tar from 6.1.0 to 6.1.11 in /ee/server/services (#23068)
  Bump @types/imap from 0.8.34 to 0.8.35 (#23122)
  Bump csv-parse from 4.16.0 to 4.16.3 (#23120)
  Language update from LingoHub 🤖 (#23123)
  Bump juice from 5.2.0 to 8.0.0 (#22177)
  [FIX] Change way emails are validated on livechat registerGuest method (#23089)
  [IMPROVE] Use PaginatedSelectFiltered in department edition (#23054)
  ...
gabriellsh added a commit that referenced this pull request Sep 14, 2021
@gabriellsh
Merge branch 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat in…
afda7d2 
…to feat/seats-cap-info-card

* 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: (59 commits)
  Chore: client endpoints typings (#23152)
  Chore: Update pino and pino-pretty (#23157)
  Bump @rocket.chat/string-helpers in /ee/server/services (#23138)
  [FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings (#22978)
  Bump xml-crypto from 2.1.2 to 2.1.3 (#23141)
  [IMPROVE] Change log format to JSON (#22975)
  Regression: Auth banner for EE (#23091)
  [IMPROVE][APPS] Return task ids when using the scheduler api (#23023)
  [FIX] Update bugsnag package (#23104)
  Bump pm2 from 5.1.0 to 5.1.1 in /ee/server/services (#23128)
  Bump @types/ejson from 2.1.2 to 2.1.3 in /ee/server/services (#23126)
  Chore: Remove non-used dependencies (#23109)
  Bump @types/ws from 7.4.6 to 7.4.7 in /ee/server/services (#23095)
  Bump tar from 6.1.0 to 6.1.11 in /ee/server/services (#23068)
  Bump @types/imap from 0.8.34 to 0.8.35 (#23122)
  Bump csv-parse from 4.16.0 to 4.16.3 (#23120)
  Language update from LingoHub 🤖 (#23123)
  Bump juice from 5.2.0 to 8.0.0 (#22177)
  [FIX] Change way emails are validated on livechat registerGuest method (#23089)
  [IMPROVE] Use PaginatedSelectFiltered in department edition (#23054)
  ...
gabriellsh added a commit that referenced this pull request Sep 14, 2021
@gabriellsh
Merge branch 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat in…
e38eaa5 
…to max-seats-backend

* 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: (61 commits)
  [NEW] Seats Card (#23077)
  Chore: client endpoints typings (#23152)
  Chore: Update pino and pino-pretty (#23157)
  Bump @rocket.chat/string-helpers in /ee/server/services (#23138)
  [FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings (#22978)
  Bump xml-crypto from 2.1.2 to 2.1.3 (#23141)
  [IMPROVE] Change log format to JSON (#22975)
  Regression: Auth banner for EE (#23091)
  [IMPROVE][APPS] Return task ids when using the scheduler api (#23023)
  [FIX] Update bugsnag package (#23104)
  Bump pm2 from 5.1.0 to 5.1.1 in /ee/server/services (#23128)
  Bump @types/ejson from 2.1.2 to 2.1.3 in /ee/server/services (#23126)
  Chore: Remove non-used dependencies (#23109)
  Bump @types/ws from 7.4.6 to 7.4.7 in /ee/server/services (#23095)
  Bump tar from 6.1.0 to 6.1.11 in /ee/server/services (#23068)
  Bump @types/imap from 0.8.34 to 0.8.35 (#23122)
  Bump csv-parse from 4.16.0 to 4.16.3 (#23120)
  Language update from LingoHub 🤖 (#23123)
  Bump juice from 5.2.0 to 8.0.0 (#22177)
  [FIX] Change way emails are validated on livechat registerGuest method (#23089)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Merged
@matheusbsilva137 matheusbsilva137 mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostjen ostjen ostjen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusbsilva137 @ostjen