[IMPROVE] Use PaginatedSelectFiltered in department edition #23054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoevanp
changed the title
tiagoevanp
approved these changes
Aug 31, 2021
gabriellsh
added a commit
that referenced
this pull request
Sep 9, 2021
…Rocket.Chat into feat/seats-cap-request-seats * 'feat/seats-cap-request-seats' of github.com:RocketChat/Rocket.Chat: (59 commits) Chore: client endpoints typings (#23152) Chore: Update pino and pino-pretty (#23157) Bump @rocket.chat/string-helpers in /ee/server/services (#23138) [FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings (#22978) Bump xml-crypto from 2.1.2 to 2.1.3 (#23141) [IMPROVE] Change log format to JSON (#22975) Regression: Auth banner for EE (#23091) [IMPROVE][APPS] Return task ids when using the scheduler api (#23023) [FIX] Update bugsnag package (#23104) Bump pm2 from 5.1.0 to 5.1.1 in /ee/server/services (#23128) Bump @types/ejson from 2.1.2 to 2.1.3 in /ee/server/services (#23126) Chore: Remove non-used dependencies (#23109) Bump @types/ws from 7.4.6 to 7.4.7 in /ee/server/services (#23095) Bump tar from 6.1.0 to 6.1.11 in /ee/server/services (#23068) Bump @types/imap from 0.8.34 to 0.8.35 (#23122) Bump csv-parse from 4.16.0 to 4.16.3 (#23120) Language update from LingoHub 🤖 (#23123) Bump juice from 5.2.0 to 8.0.0 (#22177) [FIX] Change way emails are validated on livechat registerGuest method (#23089) [IMPROVE] Use PaginatedSelectFiltered in department edition (#23054) ...
gabriellsh
added a commit
that referenced
this pull request
Sep 14, 2021
…to feat/seats-cap-info-card * 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat: (59 commits) Chore: client endpoints typings (#23152) Chore: Update pino and pino-pretty (#23157) Bump @rocket.chat/string-helpers in /ee/server/services (#23138) [FIX] Inaccurate use of 'Mobile notifications' instead of 'Push notifications' in i18n strings (#22978) Bump xml-crypto from 2.1.2 to 2.1.3 (#23141) [IMPROVE] Change log format to JSON (#22975) Regression: Auth banner for EE (#23091) [IMPROVE][APPS] Return task ids when using the scheduler api (#23023) [FIX] Update bugsnag package (#23104) Bump pm2 from 5.1.0 to 5.1.1 in /ee/server/services (#23128) Bump @types/ejson from 2.1.2 to 2.1.3 in /ee/server/services (#23126) Chore: Remove non-used dependencies (#23109) Bump @types/ws from 7.4.6 to 7.4.7 in /ee/server/services (#23095) Bump tar from 6.1.0 to 6.1.11 in /ee/server/services (#23068) Bump @types/imap from 0.8.34 to 0.8.35 (#23122) Bump csv-parse from 4.16.0 to 4.16.3 (#23120) Language update from LingoHub 🤖 (#23123) Bump juice from 5.2.0 to 8.0.0 (#22177) [FIX] Change way emails are validated on livechat registerGuest method (#23089) [IMPROVE] Use PaginatedSelectFiltered in department edition (#23054) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
When configuring the Livechat departments, not all the channels get listed in the dropdown list of channels available for offline messages to be sent.
Steps to test or reproduce
Expected Behavior:
After clicking on the dropdown, you should see a full list of all the channels created on the server and they're available to be selected.
Actual Behavior:
The dropdown lists just the first 10 channels on the server and searching for any channel (not on that list) returns an empty result.
Further comments