[FIX] Showing Workspace Section For User Having LiveChat Manager Permission #27188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filipemarins test cases falling here, I saw your name where you implemented test cases for Rocket.Chat/apps/meteor/tests/unit/client/components/AdministrationList/AdministrationModelList.spec.tsx can you help me with this? |
Codecov Report
@@ Coverage Diff @@
## develop #27188 +/- ##
===========================================
+ Coverage 41.00% 41.90% +0.89%
===========================================
Files 838 811 -27
Lines 17677 17158 -519
Branches 1983 1908 -75
===========================================
- Hits 7249 7190 -59
+ Misses 10188 9727 -461
- Partials 240 241 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
filipemarins
previously approved these changes
Dec 27, 2022
dionisio-bot
bot
added
stat: ready to merge
filipemarins
approved these changes
Jan 3, 2023
tassoevan
approved these changes
Jan 3, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 4, 2023
…ove/receipts * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Improve `ts-node` startup time with `swc` (#27686) Fix write stream error on user data export (#27683) Regression: Rectifying thread layout (#27680) [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188) [FIX] Team mention highlight EE (#27493) [IMPROVE] Save toPhone when receiving SMSs (#27656) Chore: Upgrade EE license for CI (#27682) Chore: Replace borders to `default` (#27667) Chore: Refactor message subcomponents (#27630) Regression: Fix go to ThreadList hook (#27663) Chore: Refactor e2e selectors to use roles (#27582) Chore: Composer wrapper around the textarea (#27658) [FIX] Remove invalid settings at startup (#27653)
gabriellsh
added a commit
that referenced
this pull request
Jan 5, 2023
…/freeze-custom-roles * 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits) Chore: Reduce Less usage in theming (#27689) [IMPROVE] Increase read receipt size (#27665) Chore: Improve `ts-node` startup time with `swc` (#27686) Fix write stream error on user data export (#27683) Regression: Rectifying thread layout (#27680) [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188) [FIX] Team mention highlight EE (#27493) [IMPROVE] Save toPhone when receiving SMSs (#27656) Chore: Upgrade EE license for CI (#27682) Chore: Replace borders to `default` (#27667) Chore: Refactor message subcomponents (#27630) Regression: Fix go to ThreadList hook (#27663) Chore: Refactor e2e selectors to use roles (#27582) Chore: Composer wrapper around the textarea (#27658) [FIX] Remove invalid settings at startup (#27653) Chore: Token refactor (#27655) Regression: Composer fix join room action (#27657) Regression: Sidebar collapsing on extra small views (#27651) Chore: Composer missing Slash Command preview (#27652) Chore: Custom emoji empty state (#27641) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #27081
oc-536
Steps to test or reproduce
Please refer #27081 for more details
livechat-manageruser (should not have admin role)Administration > Workspacemenu itemFurther comments
The
Workspacemenu shouldn't be visible since thelivechat-manageruser doesn't have any admin permission.