Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Refactor message subcomponents #27630

Merged
merged 25 commits into from
Dec 29, 2022
Merged

Chore: Refactor message subcomponents #27630

merged 25 commits into from
Dec 29, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the refactor/message-bits branch 2 times, most recently from fabc546 to 4b64fa5 Compare December 26, 2022 12:58
@tassoevan tassoevan force-pushed the refactor/message-bits branch from 4b64fa5 to 8b512a7 Compare December 26, 2022 20:00
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #27630 (8983d19) into develop (f79bd31) will decrease coverage by 0.81%.
The diff coverage is 53.06%.

❗ Current head 8983d19 differs from pull request most recent head 1354281. Consider uploading reports for the commit 1354281 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27630      +/-   ##
===========================================
- Coverage    42.93%   42.11%   -0.82%     
===========================================
  Files          838      812      -26     
  Lines        17685    17159     -526     
  Branches      1976     1908      -68     
===========================================
- Hits          7593     7227     -366     
+ Misses        9841     9689     -152     
+ Partials       251      243       -8     
Flag Coverage Δ
e2e 42.11% <53.06%> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Chore: refactor/message bits Chore: Refactor message subcomponents Dec 29, 2022
@tassoevan tassoevan marked this pull request as ready for review December 29, 2022 17:05
@tassoevan tassoevan requested review from a team as code owners December 29, 2022 17:05
@ggazzo
Copy link
Member

ggazzo commented Dec 29, 2022

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen worse contributions, thanks for the effort =*

@ggazzo ggazzo merged commit 350a523 into develop Dec 29, 2022
@ggazzo ggazzo deleted the refactor/message-bits branch December 29, 2022 18:40
gabriellsh added a commit that referenced this pull request Jan 4, 2023
…ove/receipts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
gabriellsh added a commit that referenced this pull request Jan 5, 2023
…/freeze-custom-roles

* 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits)
  Chore: Reduce Less usage in theming (#27689)
  [IMPROVE] Increase read receipt size (#27665)
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
  Chore: Token refactor (#27655)
  Regression: Composer fix join room action (#27657)
  Regression: Sidebar collapsing on extra small views (#27651)
  Chore: Composer missing Slash Command preview (#27652)
  Chore: Custom emoji empty state (#27641)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants