Chore: use useQuery in place of deprecated useEndpointData #27673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
changed the title
|
Ftr, this pr is overlapping with #27646 this a little bit for now. |
|
Thank you for the heads up! I'll take care not to touch the components where the existing PR(27646) has already updated the hooks. |
Dnouv
force-pushed
the
remove_deprecated_user_dashboard
branch
from
1cb8116 to
afc85a0
Compare
tassoevan
requested changes
Jan 10, 2023
There was a problem hiding this comment.
I've made some suggestions regarding the query keys, based on some patterns that I coincidentally discussed with @dougfabris today: https://tkdodo.eu/blog/effective-react-query-keys
apps/meteor/client/views/admin/apps/AppDetailsPage/tabs/AppReleases/AppReleases.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/customEmoji/EditCustomEmojiWithData.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/customSounds/AdminSoundsRoute.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/customSounds/EditCustomSound.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/customUserStatus/CustomUserStatusFormWithData.tsx
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @tassoevan. The article shared was a good read. I have made the required changes. |
tassoevan
previously approved these changes
Jan 11, 2023
tassoevan
requested changes
Jan 11, 2023
apps/meteor/client/views/admin/customSounds/EditCustomSound.tsx
Outdated
Show resolved
Hide resolved
tassoevan
requested changes
Jan 12, 2023
apps/meteor/client/views/admin/customSounds/EditCustomSound.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/apps/AppDetailsPage/tabs/AppReleases/AppReleases.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #27673 +/- ##
===========================================
+ Coverage 42.03% 43.17% +1.14%
===========================================
Files 842 815 -27
Lines 17604 17090 -514
Branches 2013 1938 -75
===========================================
- Hits 7399 7379 -20
+ Misses 9939 9442 -497
- Partials 266 269 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Dnouv
force-pushed
the
remove_deprecated_user_dashboard
branch
from
ab68402 to
c58d09d
Compare
Dnouv
force-pushed
the
remove_deprecated_user_dashboard
branch
from
c58d09d to
5f8873c
Compare
tassoevan
approved these changes
Jan 26, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Feb 6, 2023
….Chat into matrixSearch * 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits) fix: removing file wrongly merged on update merge [NEW] Federation search public rooms in the Matrix network (#27434) Chore: Refactor other kinds of message - Phase 2 (#27927) Chore: improve some e2e selectors (#27936) [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744) Chore: Notify Marketplace on App Install (#27925) i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814) [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929) Chore: Migrate cached collections to TypeScript (#27909) i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705) [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911) [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539) Chore: Improve service's licence check (#27872) [IMPROVE] Livechat Persian translation (#27825) Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884) Chore: use useQuery in place of deprecated useEndpointData (#27673) Chore: Update Some Composer Icons (#27862) Regression: Undefined default message context (#27870) Chore: Remove OS version for device management (#27786) [BREAK] Remove less theming (#27647) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
useQueryinstead of the deprecateduseEndpointDatafor the Users Table under the Admin console.Thank you!
Proposed changes (including videos or screenshots)
Chore done:
useEndpointData -> useEndpoint for:
/apps/meteor/client/views/admin/appscustomEmojicustomSoundscustomUserStatusintegrationsinvitesoauthAppspermissionsroomsusersIssue(s)
Steps to test or reproduce
Further comments