-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] [NEW] Custom roles upsell modal #27707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
changed the title
[BREAK][NEW]: Custom roles upsell modal
[BREAK] [NEW]: Custom roles upsell modal
Jan 9, 2023
…customRolesUpsell * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Composer Toolbox overlapping borders (#27714) [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533) [FIX] Discussion visibility when inside a private team. (#27601) Chore: Restrict legacy message events (#27691) [FIX] Anonymous user buttons (#27551) [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703) [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
dougfabris
changed the title
[BREAK] [NEW]: Custom roles upsell modal
[BREAK] [NEW] Custom roles upsell modal
Jan 17, 2023
yash-rajpal
previously approved these changes
Jan 18, 2023
Codecov Report
@@ Coverage Diff @@
## develop #27707 +/- ##
===========================================
+ Coverage 42.14% 43.00% +0.86%
===========================================
Files 848 818 -30
Lines 17555 17243 -312
Branches 2078 1939 -139
===========================================
+ Hits 7399 7416 +17
+ Misses 9875 9562 -313
+ Partials 281 265 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
previously approved these changes
Jan 19, 2023
hugocostadev
suggested changes
Jan 19, 2023
apps/meteor/client/views/admin/permissions/PermissionsTable/PermissionsTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/permissions/PermissionsRouter.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/permissions/PermissionsContextBar.tsx
Outdated
Show resolved
Hide resolved
hugocostadev
previously approved these changes
Jan 25, 2023
hugocostadev
previously approved these changes
Feb 2, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Feb 2, 2023
rodrigok
changed the title
[BREAK] [NEW] Custom roles upsell modal
[BREAK][NEW] Custom roles upsell modal
Feb 7, 2023
rodrigok
changed the title
[BREAK][NEW] Custom roles upsell modal
[BREAK] [NEW] Custom roles upsell modal
Feb 7, 2023
rodrigok
requested changes
Feb 7, 2023
rodrigok
approved these changes
Feb 8, 2023
yash-rajpal
approved these changes
Feb 8, 2023
gabriellsh
added a commit
that referenced
this pull request
Feb 13, 2023
…e/wizard * 'develop' of github.com:RocketChat/Rocket.Chat: [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969) [NEW] Emojis rendering properly on quote message previews (#27972) Chore: Wait message to not be Busy (#28000) Chore: e2e changes tests (#27987) [IMPROVE] Audit (#27994) [IMPROVE] Registration Experience (#27820) [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854) [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902) [NEW] Permission to bypass message editing and removing limits (#27644) [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764) Chore: Set missing colors (#27817) Fix CI Chore: undo busy selector [BREAK] Remove message view mode from User Preferences (#27867) Chore: Aria busy indicators (#27978) Chore: Refactor Composer Dropdown (#27931) Chore: Added Enterprise Options to Login customization (#27855) [FIX] Ignored messages reactivity (#27279) [BREAK] [NEW] Custom roles upsell modal (#27707)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Also changed the
edit role
button:Issue(s)
Steps to test or reproduce
Further comments
TC-332