Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] [NEW] Custom roles upsell modal #27707

Merged
merged 21 commits into from
Feb 8, 2023
Merged

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

image

Also changed the edit role button:
image

Issue(s)

Steps to test or reproduce

Further comments

TC-332

@gabriellsh gabriellsh changed the title [BREAK][NEW]: Custom roles upsell modal [BREAK] [NEW]: Custom roles upsell modal Jan 9, 2023
…customRolesUpsell

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Composer Toolbox overlapping borders (#27714)
  [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533)
  [FIX] Discussion visibility when inside a private team. (#27601)
  Chore: Restrict legacy message events (#27691)
  [FIX] Anonymous user buttons (#27551)
  [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703)
  [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
@gabriellsh gabriellsh marked this pull request as ready for review January 12, 2023 16:15
@gabriellsh gabriellsh requested review from a team as code owners January 12, 2023 16:15
@yash-rajpal yash-rajpal added this to the 6.0.0 milestone Jan 12, 2023
@dougfabris dougfabris changed the title [BREAK] [NEW]: Custom roles upsell modal [BREAK] [NEW] Custom roles upsell modal Jan 17, 2023
yash-rajpal
yash-rajpal previously approved these changes Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #27707 (d656eda) into develop (d13110f) will increase coverage by 0.86%.
The diff coverage is n/a.

❗ Current head d656eda differs from pull request most recent head 4f20298. Consider uploading reports for the commit 4f20298 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27707      +/-   ##
===========================================
+ Coverage    42.14%   43.00%   +0.86%     
===========================================
  Files          848      818      -30     
  Lines        17555    17243     -312     
  Branches      2078     1939     -139     
===========================================
+ Hits          7399     7416      +17     
+ Misses        9875     9562     -313     
+ Partials       281      265      -16     
Flag Coverage Δ
e2e 43.00% <ø> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

yash-rajpal
yash-rajpal previously approved these changes Jan 19, 2023
hugocostadev
hugocostadev previously approved these changes Jan 25, 2023
hugocostadev
hugocostadev previously approved these changes Feb 2, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 2, 2023
@rodrigok rodrigok changed the title [BREAK] [NEW] Custom roles upsell modal [BREAK][NEW] Custom roles upsell modal Feb 7, 2023
@rodrigok rodrigok changed the title [BREAK][NEW] Custom roles upsell modal [BREAK] [NEW] Custom roles upsell modal Feb 7, 2023
@kodiakhq kodiakhq bot merged commit 7f507c1 into develop Feb 8, 2023
@kodiakhq kodiakhq bot deleted the new/customRolesUpsell branch February 8, 2023 21:59
gabriellsh added a commit that referenced this pull request Feb 13, 2023
…e/wizard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969)
  [NEW] Emojis rendering properly on quote message previews (#27972)
  Chore: Wait message to not be Busy (#28000)
  Chore: e2e changes tests (#27987)
  [IMPROVE] Audit (#27994)
  [IMPROVE] Registration Experience (#27820)
  [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854)
  [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902)
  [NEW] Permission to bypass message editing and removing limits (#27644)
  [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764)
  Chore: Set missing colors (#27817)
  Fix CI
  Chore: undo busy selector
  [BREAK] Remove message view mode from User Preferences (#27867)
  Chore: Aria busy indicators (#27978)
  Chore: Refactor Composer Dropdown (#27931)
  Chore: Added Enterprise Options to Login customization (#27855)
  [FIX] Ignored messages reactivity (#27279)
  [BREAK] [NEW] Custom roles upsell modal (#27707)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants