[BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks #27902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPierdona
commented
Feb 1, 2023
apps/meteor/app/ui-message/client/messageBox/messageBoxFormatting.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/ui-message/client/messageBox/messageBoxFormatting.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/ui-message/client/messageBox/messageBoxFormatting.ts
Outdated
Show resolved
Hide resolved
hugocostadev
suggested changes
Feb 3, 2023
apps/meteor/app/ui-message/client/messageBox/messageBoxFormatting.ts
Outdated
Show resolved
Hide resolved
|
Oh, I think that you forgot to remove this: |
Codecov Report
@@ Coverage Diff @@
## develop #27902 +/- ##
===========================================
+ Coverage 41.62% 42.73% +1.10%
===========================================
Files 849 807 -42
Lines 17560 16768 -792
Branches 2087 1993 -94
===========================================
- Hits 7310 7166 -144
+ Misses 9976 9328 -648
Partials 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
previously approved these changes
Feb 9, 2023
…cated-settings-message-parser
hugocostadev
previously approved these changes
Feb 9, 2023
…cated-settings-message-parser
|
@LucianoPierdona can you list in the PR's body all the settings that were removed? |
rodrigok
requested changes
Feb 10, 2023
|
@rodrigok added list of removed settings in the description |
|
@LucianoPierdona the |
rodrigok
requested changes
Feb 10, 2023
|
@rodrigok removed snippet logic and also removed API_EmbedDisabledFor |
rodrigok
requested changes
Feb 10, 2023
rodrigok
changed the title
rodrigok
approved these changes
Feb 10, 2023
hugocostadev
approved these changes
Feb 10, 2023
kodiakhq
bot
deleted the
break/remove-deprecated-settings-message-parser
branch
gabriellsh
added a commit
that referenced
this pull request
Feb 13, 2023
…e/wizard * 'develop' of github.com:RocketChat/Rocket.Chat: [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969) [NEW] Emojis rendering properly on quote message previews (#27972) Chore: Wait message to not be Busy (#28000) Chore: e2e changes tests (#27987) [IMPROVE] Audit (#27994) [IMPROVE] Registration Experience (#27820) [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854) [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902) [NEW] Permission to bypass message editing and removing limits (#27644) [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764) Chore: Set missing colors (#27817) Fix CI Chore: undo busy selector [BREAK] Remove message view mode from User Preferences (#27867) Chore: Aria busy indicators (#27978) Chore: Refactor Composer Dropdown (#27931) Chore: Added Enterprise Options to Login customization (#27855) [FIX] Ignored messages reactivity (#27279) [BREAK] [NEW] Custom roles upsell modal (#27707)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed Settings:
Issue(s)
Steps to test or reproduce
Further comments
TC-370