[BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks

apps/meteor/app/api/server/lib/messages.ts

@@ -3,7 +3,6 @@ import type { IMessage, IUser } from '@rocket.chat/core-typings';
 import { Rooms, Messages, Users } from '@rocket.chat/models';
 
 import { canAccessRoomAsync } from '../../../authorization/server/functions/canAccessRoom';
-import { getValue } from '../../../settings/server/raw';
 
 export async function findMentionedMessages({
 	uid,
@@ -84,10 +83,6 @@ export async function findStarredMessages({
 }
 
 export async function findSnippetedMessageById({ uid, messageId }: { uid: string; messageId: string }): Promise<IMessage> {
-	if (!(await getValue('Message_AllowSnippeting'))) {
-		throw new Error('error-not-allowed');
-	}
-
 	if (!uid) {
 		throw new Error('invalid-user');
 	}
@@ -125,9 +120,6 @@ export async function findSnippetedMessages({
 	offset: number;
 	total: number;
 }> {
-	if (!(await getValue('Message_AllowSnippeting'))) {
-		throw new Error('error-not-allowed');
-	}
 	const room = await Rooms.findOneById(roomId);
 
 	if (!room || !(await canAccessRoomAsync(room, { _id: uid }))) {

apps/meteor/app/autotranslate/server/autotranslate.ts

@@ -165,7 +165,7 @@ export abstract class AutoTranslate {
 	tokenizeURLs(message: IMessage): IMessage {
 		let count = message.tokens?.length || 0;
 
-		const schemes = settings.get<string>('Markdown_SupportSchemesForLink')?.split(',').join('|');
+		const schemes = 'http,https';
 
 		// Support ![alt text](http://image url) and [text](http://link)
 		message.msg = message.msg.replace(

apps/meteor/app/lib/server/functions/loadMessageHistory.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/explicit-function-return-type */
-import { settings } from '../../../settings/server';
 import { Messages, Rooms } from '../../../models/server';
 import { normalizeMessagesForUser } from '../../../utils/server/lib/normalizeMessagesForUser';
 import { getHiddenSystemMessages } from '../lib/getHiddenSystemMessages';
@@ -34,12 +33,6 @@ export function loadMessageHistory({
 		fields: {},
 	};
 
-	if (!settings.get('Message_ShowEditedStatus')) {
-		options.fields = {
-			editedAt: 0,
-		};
-	}
-
 	const records =
 		end != null
 			? Messages.findVisibleByRoomIdBeforeTimestampNotContainingTypes(rid, end, hiddenMessageTypes, options, showThreadMessages).fetch()

apps/meteor/app/lib/server/methods/getChannelHistory.ts

@@ -4,7 +4,6 @@ import _ from 'underscore';
 
 import { canAccessRoom, hasPermission } from '../../../authorization/server';
 import { Subscriptions, Messages, Rooms } from '../../../models/server';
-import { settings } from '../../../settings/server';
 import { normalizeMessagesForUser } from '../../../utils/server/lib/normalizeMessagesForUser';
 import { getHiddenSystemMessages } from '../lib/getHiddenSystemMessages';
 
@@ -59,10 +58,6 @@ Meteor.methods({
 			limit: count,
 		};
 
-		if (!settings.get('Message_ShowEditedStatus')) {
-			options.fields = { editedAt: 0 };
-		}
-
 		const records = _.isUndefined(oldest)
 			? Messages.findVisibleByRoomIdBeforeTimestampNotContainingTypes(
 					rid,

apps/meteor/app/lib/server/startup/settings.ts

@@ -548,13 +548,6 @@ settingsRegistry.addGroup('Accounts', function () {
 			public: true,
 			i18nLabel: 'Notifications_Sound_Volume',
 		});
-
-		this.add('Accounts_Default_User_Preferences_useLegacyMessageTemplate', false, {
-			type: 'boolean',
-			public: true,
-			i18nLabel: 'Use_Legacy_Message_Template',
-			alert: 'This_is_a_deprecated_feature_alert',
-		});
 	});
 
 	this.section('Avatar', function () {
@@ -1159,13 +1152,6 @@ settingsRegistry.addGroup('General', function () {
 
 settingsRegistry.addGroup('Message', function () {
 	this.section('Message_Attachments', function () {
-		this.add('Message_Attachments_GroupAttach', false, {
-			type: 'boolean',
-			public: true,
-			i18nDescription: 'Message_Attachments_GroupAttachDescription',
-			alert: 'This_is_a_deprecated_feature_alert',
-		});
-
 		this.add('Message_Attachments_Thumbnails_Enabled', true, {
 			type: 'boolean',
 			public: true,
@@ -1240,11 +1226,6 @@ settingsRegistry.addGroup('Message', function () {
 	this.add('Message_AlwaysSearchRegExp', false, {
 		type: 'boolean',
 	});
-	this.add('Message_ShowEditedStatus', true, {
-		type: 'boolean',
-		public: true,
-		alert: 'This_is_a_deprecated_feature_alert',
-	});
 	this.add('Message_ShowDeletedStatus', false, {
 		type: 'boolean',
 		public: true,
@@ -1277,14 +1258,6 @@ settingsRegistry.addGroup('Message', function () {
 		type: 'boolean',
 		public: true,
 	});
-	/**
-	 * @deprecated
-	 */
-	this.add('Message_ShowFormattingTips', true, {
-		type: 'boolean',
-		public: true,
-		alert: 'This_is_a_deprecated_feature_alert',
-	});
 	this.add('Message_GroupingPeriod', 300, {
 		type: 'int',
 		public: true,
@@ -1311,22 +1284,6 @@ settingsRegistry.addGroup('Message', function () {
 		actionText: 'clear',
 		i18nLabel: 'clear_cache_now',
 	});
-	// TODO: deprecate this setting in favor of App
-	this.add('API_EmbedDisabledFor', '', {
-		type: 'string',
-		public: true,
-		i18nDescription: 'API_EmbedDisabledFor_Description',
-		alert: 'This_is_a_deprecated_feature_alert',
-	});
-	// TODO: deprecate this setting in favor of App
-	this.add('API_EmbedIgnoredHosts', 'localhost, 127.0.0.1, 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16', {
-		type: 'string',
-		i18nDescription: 'API_EmbedIgnoredHosts_Description',
-	});
-	// TODO: deprecate this setting in favor of App
-	this.add('API_EmbedSafePorts', '80, 443', {
-		type: 'string',
-	});
 	this.add('Message_TimeFormat', 'LT', {
 		type: 'string',
 		public: true,

apps/meteor/app/markdown/lib/markdown.js

@@ -9,7 +9,6 @@ import { marked } from './parser/marked/marked';
 import { original } from './parser/original/original';
 import { filtered } from './parser/filtered/filtered';
 import { code } from './parser/original/code';
-import { settings } from '../../settings';
 
 const parsers = {
 	original,
@@ -33,29 +32,11 @@ class MarkdownClass {
 	}
 
 	parseMessageNotEscaped(message) {
-		const parser = settings.get('Markdown_Parser');
-
-		if (parser === 'disabled') {
-			return message;
-		}
-
 		const options = {
-			supportSchemesForLink: settings.get('Markdown_SupportSchemesForLink'),
-			headers: settings.get('Markdown_Headers'),
 			rootUrl: Meteor.absoluteUrl(),
-			marked: {
-				gfm: settings.get('Markdown_Marked_GFM'),
-				tables: settings.get('Markdown_Marked_Tables'),
-				breaks: settings.get('Markdown_Marked_Breaks'),
-				pedantic: settings.get('Markdown_Marked_Pedantic'),
-				smartLists: settings.get('Markdown_Marked_SmartLists'),
-				smartypants: settings.get('Markdown_Marked_Smartypants'),
-			},
 		};
 
-		const parse = typeof parsers[parser] === 'function' ? parsers[parser] : parsers.original;
-
-		return parse(message, options);
+		return parsers.original(message, options);
 	}
 
 	mountTokensBackRecursively(message, tokenList, useHtml = true) {
@@ -91,30 +72,22 @@ class MarkdownClass {
 	}
 
 	filterMarkdownFromMessage(message) {
-		return parsers.filtered(message, {
-			supportSchemesForLink: settings.get('Markdown_SupportSchemesForLink'),
-		});
+		return parsers.filtered(message);
 	}
 }
 
 export const Markdown = new MarkdownClass();
 
 export const filterMarkdown = (message) => Markdown.filterMarkdownFromMessage(message);
 
-export const createMarkdownMessageRenderer = ({ parser, ...options }) => {
-	if (!parser || parser === 'disabled') {
-		return (message) => message;
-	}
-
-	const parse = typeof parsers[parser] === 'function' ? parsers[parser] : parsers.original;
-
+export const createMarkdownMessageRenderer = ({ ...options }) => {
 	return (message) => {
 		if (!message?.html?.trim()) {
 			return message;
 		}
 
-		return parse(message, options);
+		return parsers.original(message, options);
 	};
 };
 
-export const createMarkdownNotificationRenderer = (options) => (message) => parsers.filtered(message, options);
+export const createMarkdownNotificationRenderer = () => (message) => parsers.filtered(message);

apps/meteor/app/markdown/server/index.js

@@ -2,35 +2,20 @@ import { Meteor } from 'meteor/meteor';
 import { Tracker } from 'meteor/tracker';
 
 import { callbacks } from '../../../lib/callbacks';
-import { settings } from '../../settings/server';
 import { createMarkdownMessageRenderer, createMarkdownNotificationRenderer } from '../lib/markdown';
-import './settings';
 
 export { Markdown } from '../lib/markdown';
 
 Meteor.startup(() => {
 	Tracker.autorun(() => {
 		const options = {
-			parser: settings.get('Markdown_Parser'),
-			supportSchemesForLink: settings.get('Markdown_SupportSchemesForLink'),
-			headers: settings.get('Markdown_Headers'),
 			rootUrl: Meteor.absoluteUrl(),
-			marked: {
-				gfm: settings.get('Markdown_Marked_GFM'),
-				tables: settings.get('Markdown_Marked_Tables'),
-				breaks: settings.get('Markdown_Marked_Breaks'),
-				pedantic: settings.get('Markdown_Marked_Pedantic'),
-				smartLists: settings.get('Markdown_Marked_SmartLists'),
-				smartypants: settings.get('Markdown_Marked_Smartypants'),
-			},
 		};
 
 		const renderMessage = createMarkdownMessageRenderer(options);
 		callbacks.add('renderMessage', renderMessage, callbacks.priority.HIGH, 'markdown');
 	});
 
-	const renderNotification = createMarkdownNotificationRenderer({
-		supportSchemesForLink: settings.get('Markdown_SupportSchemesForLink'),
-	});
+	const renderNotification = createMarkdownNotificationRenderer();
 	callbacks.add('renderNotification', renderNotification, callbacks.priority.HIGH, 'filter-markdown');
 });