Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: system message copy updates #29372

Merged
merged 15 commits into from
Jun 7, 2023
Merged

Conversation

heitortanoue
Copy link
Contributor

@heitortanoue heitortanoue commented May 25, 2023

Added the messages of:

  • "removed__username__as__role__"
  • "set__username__as__role__"
  • "changed_room_announcement_to__room_announcement_"
  • "changed_room_description_to__room_description_"

TC-549 TC-725

@heitortanoue heitortanoue requested a review from a team as a code owner May 25, 2023 21:46
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 83e6367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gabriellsh
gabriellsh previously approved these changes May 26, 2023
gabriellsh
gabriellsh previously approved these changes May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #29372 (83e6367) into develop (29556cb) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29372      +/-   ##
===========================================
- Coverage    46.75%   46.68%   -0.08%     
===========================================
  Files          699      699              
  Lines        13082    13081       -1     
  Branches      2229     2228       -1     
===========================================
- Hits          6117     6107      -10     
- Misses        6645     6651       +6     
- Partials       320      323       +3     
Flag Coverage Δ
e2e 46.66% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@heitortanoue heitortanoue requested a review from a team as a code owner May 30, 2023 00:50
heitortanoue and others added 4 commits May 30, 2023 17:55
…e/system-messages-update

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  fix: Importer crashes when sending the "active status" e-mail notification to users (#29401)
  docs: new README file (#27955)
  refactor: replace with new `Select` (#29368)
  fix: Sidebar's sort by name not being checked properly (#29415)
  fix: Login Terms custom content (#28999)
  fix: Broken link fixed inside webhook menu (#29048)
  fix: Apps settings i18n translation (#29394)
  fix: OTR session closing after 10 seconds without warning (#29245)
  fix: Register Username form showing before homepage (#29356)
  regression(ui-client): Toolbox action button badge in the wrong position (#29412)
  fix: marketplace filters are changing size (#28738)
  chore: Update highlighted word color (#29407)
  i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317)
  chore(ddp-sdk): ts-jest -> swc/jest (#29380)
  chore: `ToolboxAction` pressed state (#29397)
  chore: add logs to recurring omnichannel cron jobs (#29392)
  regression: `t` using always sprintf (#29396)
  fix: fix wrong %s translations (#29395)
  regression(push): fix error when selecting what to import (#29289)
  chore: Change ddpsdk.stream to return subscription (#29375)
  ...
…Rocket.Chat into chore/system-messages-update

* 'chore/system-messages-update' of github.com:RocketChat/Rocket.Chat:
  make different key for the new strings
  fix leader msg
  remove duplicates
gabriellsh
gabriellsh previously approved these changes Jun 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 2, 2023
@jessicaschelly jessicaschelly removed the stat: ready to merge PR tested and approved waiting for merge label Jun 2, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 2, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 5, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 5, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 5, 2023
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering if this should be an improvement instead
lgtm anyways

@matheusbsilva137 matheusbsilva137 added the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2023
@heitortanoue heitortanoue changed the title chore: system message copy updates improve: system message copy updates Jun 7, 2023
@matheusbsilva137 matheusbsilva137 changed the title improve: system message copy updates i18n: system message copy updates Jun 7, 2023
@kodiakhq kodiakhq bot merged commit ea0bbba into develop Jun 7, 2023
@kodiakhq kodiakhq bot deleted the chore/system-messages-update branch June 7, 2023 22:39
@scuciatto scuciatto added this to the 6.3.0 milestone Jun 8, 2023
gabriellsh added a commit that referenced this pull request Jun 12, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (43 commits)
  chore: Pages empty state consistency (#29439)
  refactor: Convert Omnichannel helper ee to ts (#29274)
  regression(i18n): Broken translations on client-side startup (#29442)
  chore: break down helpers.ts and create new files (#28611)
  test: runInBand unit test (#29484)
  i18n: system message copy updates (#29372)
  chore: emoji popup trigger length (#29282)
  fix: Seat counter including apps (#29489)
  fix: Invalid message draft (#29474)
  fix: message deletion fails if has files attached on filesystem storage (#29313)
  chore: replace meteor.call -> sdk.call (#29318)
  chore: deprecation api (#29347)
  fix: Imported messages are not displayed (#29416)
  chore: convert metrics to ts (#29475)
  chore: use new Livechat SDK Implementation (#29098)
  fix: Room history scroll position (#29335)
  fix: check for $addToSet to be not empty before passing update params (#29378)
  chore: update `badge-level-0` color (#29460)
  fix: Saving Business hour throws an alert (#29449)
  regression: emojiPicker position (#29408)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants