[new] global search across channel

[cyberhck]

@RocketChat/core

Closes #1615

it's really difficult to explain with screenshots, basically this PR enables global search without breaking existing functionality. One optional parameter is now passed to enable global search.

This is my first time doing meteor, so I will need a review.

If there are any changes you'd like, please let me know and I'll fix it.

Thanks.

[CLAassistant]

All committers have signed the CLA.

[cyberhck]

Anything going on with this PR?

[gdelavald]

Not sure if this is necessary.

[cyberhck]

ahh, if the connection isn't very good, it sometimes takes some time to go to other room, and it was giving errors, is there a promise or callback which I can use?

I tried without setTimeout because this feels very dirty, it worked the first time because it was instant, then it stopped working.

[gdelavald]

Hey @cyberhck, thanks for the Pull Request!
Looks like this change makes the default search to global, I think it would be very cool to be able to toggle that in the search interface (with a checkbox perhaps?).

[cyberhck]

@gdelavald I was definitely thinking that.

I looked into slack and other chats, there were only global ones, and since I'm poor in designing, I wasn't so sure whee to put the checkbox in :)

If you have any suggestions, I'd be more than happy to update.
Thanks :)

[gdelavald]

I think the easier/simpler way would be doing something like this:

We can discuss style later, I would like to see the functionality implemented first.
Also, the search result ends up being a big list without displaying from which channel came which message, I think that would be pretty interesting to see as well.

[cyberhck]

Okay, I'll keep add this to my do list for tonight :) thanks for feedback

[cyberhck]

I've been quite busy lately, I'll give this a go again when I have a little breathing room, or if anyone else wants to take it from here, I'm okay with that, (don't care for the bounty, whoever finishes may take it 🙂 )

[Cu57arD]

I have added $200 to the bounty - https://www.bountysource.com/issues/28998888-global-search-across-channels