[NEW] Global message search (beta: disabled by default) #9687
Conversation
# Conflicts: # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-ui-flextab/client/tabs/messageSearch.html # packages/rocketchat-ui-flextab/client/tabs/messageSearch.js # packages/rocketchat-ui-message/client/message.js # server/methods/messageSearch.js
|
Can I work on this issue? |
|
What about combining this with #8714 ? Seems like proper implementation here would be to plug this up as providers. Default provider of search being this one. But being able to plug in external provider would be the perfect solution. It seems like we really should do this properly instead of just merging alone? Or if we merge alone we need to make sure and let everyone know what are plans are? @RocketChat/core thoughts?
|
|
wow, the UI looks million times better than what I saw last time. (again, I'm poor in design) |
|
@geekgonecrazy would be awesome for a future implementation, the idea here is to have a working solution to solve some team issues while trying to find the correct message, wasn't developed to be the best option. But I'd lide to see a better implementation in the future to improve this. |
|
In the future, yes, the provider option should be the way to go, maybe one wants different types of search, maybe someone might want to index stuff on elastic search, and maybe keywords and stuff, provider should be quite good. But for now since this is a highly asked feature, I think it's a good idea to get this first, but it's upto maintainers, so. |
|
Will be having conversations to attempt the provider approach after this PR. 👍 might as well include this behind beta flag and get some bugs found, reported and fixed. |
|
Hi all! As you might already heard from @mrsimpson we are currently working on a search provider concept for Rocketchat. As we are working with solr for a long time, we already implemented a search provider for solr (which we now slightly adapt to fit the provider concept). You can see the current status in a nice gif (thx @mrsimpson) here redlink-gmbh/chatpal-search#14 (comment). We will have a alpha version of the concept mid of next week and would looking forward to present and discuss it with you! |
rodrigok
force-pushed
the
global-search
branch
from
4d731fe to
967d7aa
Compare
| if (window.matchMedia('(max-width: 500px)').matches) { | ||
| Template.instance().tabBar.close(); | ||
| } | ||
|
|
||
| RoomHistoryManager.getSurroundingMessages(message, 50); | ||
| window.setTimeout(() => { | ||
| RoomHistoryManager.getSurroundingMessages(message, 50); |
There was a problem hiding this comment.
I see this is still there, I was trying so hard to find if there's any other way than setting a timeout, looks like FlowRouter.goToRoomById doesn't return any promise nor does it have callbacks
|
Surely this feature should be finished properly and enabled by default by now? |
|
Hi, I'm new here, and very much interested on the developing of the global search in Rocket.Chat. My team is using rocket chat and for the short period of time it was available, it was really helpful! @tkurz could you help me to understand the current state? |
Description
It adds a new setting to enable the global search beta feature allowing users to search messages using the contextual bar (right bar) and choose to receive results from the current room only or from all rooms that he already joined.
Settings
@RocketChat/core
Based on #7628 and #7274 thanks @cyberhck and @savikko
Closes #7628
Closes #7274
Closes #1615
@karlprieb we need to improve the checkbox ui at search contextual bar