Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Adapt 0.61 design (context bar and theming) #14

Merged
merged 8 commits into from
Feb 19, 2018

Conversation

mrsimpson
Copy link
Contributor

With 0.61, Rocket.Chat releases the new context bar.
However, this needs some adaptation with respect to chatpal integration.

I moved the input statically to the left, but this is only a very quick fix.
cp moved left

Problems found:

  • Selecting an item from the context bar does not make chatpal tab disappear
  • Chatpal tab overlaps context tooltip

hidden

- Input needs to be aligned dynamically different on `home` and channels

cp home

@mrsimpson
Copy link
Contributor Author

mrsimpson commented Feb 6, 2018

@tkurz you can checkout the assistify 0.61-branch in order to reproduce it easily

Btw: Of course I don't think that this "fix" is the proper solution. I basically wanted to point you to the fact that the UI has changed and that this has implications on the current implementation.

My suggestion for the first step is to basically re-use the existing search tab. Place the chatpal search dialog into the tab and display/hide it as any other normal tab.
This is not perfect from a UX perspective (since actually, the search is global and not related to the room), but until there's a proposal from Rocket.Chat how to design that, this is the easiest way

In oder to be as compatible to the standard search as possible, moved the whole Chatpal search to the tab bar.
- remove the "global" search bar
- use a normal tab as container
- adapted to 0.61 design (sharp corners and edges, colors)

This - of course - has some limitations:
- the search vanishes when switching the room - but it miraculously remains opened when navigating, which is nice.
- On `home`, there is no search option
@mrsimpson
Copy link
Contributor Author

@tkurz @vickyokrm I moved the search and its results fully to the tab bar. See the comment of 3a22aae for details

@mrsimpson mrsimpson changed the title Adapt 0.61 context bar Adapt 0.61 design (context bar and theming) Feb 8, 2018
@mrsimpson
Copy link
Contributor Author

@tkurz this is how it currently looks like //cc @geekgonecrazy
demo-chatpal

@tkurz
Copy link
Member

tkurz commented Feb 12, 2018

Hi @mrsimpson
I like the video a lot, also the integration into the right side flex tab bar. There are only two smaller things. 1st) a direct search input on top would be amazing and 2nd) the search should appear already on the start screen (where the flex tab currently is not available). But this would need adaptions of rocket.chat. Nice work!

@mrsimpson
Copy link
Contributor Author

@tkurz don't merge this yet - there's some substantial bug to be fixed:

The swapping of the search only works for the user who activates Chatpal.

@tkurz tkurz merged commit 288947f into redlink-gmbh:master Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants