Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Added support for Dataporten's userid-feide scope #8627

Closed
wants to merge 1 commit into from
Closed

[NEW] Added support for Dataporten's userid-feide scope #8627

wants to merge 1 commit into from

Conversation

torgeirl
Copy link
Contributor

@torgeirl torgeirl commented Oct 24, 2017

@RocketChat/core

Dataporten has two OAuth scopes for usernames. In addition to the userid scope (an unique string) currently supported by Rocket.Chat a more human-readable userid-feide scope (an unique username) is available as explained in Dataporten's documentation.

With this commit, if the Rocket.Chat administrator add the userid-feide scope to your app's configuration in the Dataporten Dashboard, the username will be set to the unique username over the unique string.

Screenshot
Dataporten login with the test user eva_student before and after the changes in the commit:
screenshot from 2017-10-24 11-15-05
Of note, the test user's username has a slightly different form than a real user's would. Ie. the user ola at the Norwegian University of Science and Technology (NTNU) would be named feide:ola@ntnu.no.

@torgeirl
Copy link
Contributor Author

This is sort-of related to issue #3580, fixed when @kasperrt added support for the userid scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant