Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Added support for Dataporten's userid-feide scope #8902

Merged
merged 5 commits into from
Dec 8, 2017
Merged

[NEW] Added support for Dataporten's userid-feide scope #8902

merged 5 commits into from
Dec 8, 2017

Conversation

torgeirl
Copy link
Contributor

@RocketChat/core

Dataporten has two OAuth scopes for usernames. In addition to the userid scope (an unique string) currently supported by Rocket.Chat a more human-readable userid-feide scope (an unique username) is available as explained in Dataporten's documentation.

With this commit, if the Rocket.Chat administrator add the userid-feide scope to your app's configuration in the Dataporten Dashboard, the username will be set to the unique username over the unique string.

Screenshot
Dataporten login with the test user eva_student before and after the changes in the commit:
screenshot from 2017-10-24 11-15-05
Of note, the test user's username has a slightly different form than a real user's would. Ie. the user ola at the Norwegian University of Science and Technology (NTNU) would be named feide:ola@ntnu.no.

(This was originally submitted as PR #8627, but that got permanently closed when I tried to close and reopen it to re-trigger the Travis test since I had managed to delete the repository that submitted the PR. It seemed the Travis test failed for something unrelated to this minor code change.)

@graywolf336
Copy link
Contributor

Does this change only apply to new users or will it be effecting existing users?

@torgeirl
Copy link
Contributor Author

torgeirl commented Dec 5, 2017

@graywolf336: the change only effects new users; existing users can log in as before, and their usernames remain unchanged (the long unique string). Verified using 0.60.0-develop branch.

@graywolf336
Copy link
Contributor

Okay cool, thanks!

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 8, 2017
@rodrigok rodrigok merged commit b444159 into RocketChat:develop Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants