[NEW] Added support for Dataporten's userid-feide scope #8902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Dataporten has two OAuth scopes for usernames. In addition to the
userid
scope (an unique string) currently supported by Rocket.Chat a more human-readableuserid-feide
scope (an unique username) is available as explained in Dataporten's documentation.With this commit, if the Rocket.Chat administrator add the
userid-feide
scope to your app's configuration in the Dataporten Dashboard, the username will be set to the unique username over the unique string.Screenshot
Dataporten login with the test user
eva_student
before and after the changes in the commit:Of note, the test user's username has a slightly different form than a real user's would. Ie. the user
ola
at the Norwegian University of Science and Technology (NTNU) would be namedfeide:ola@ntnu.no
.(This was originally submitted as PR #8627, but that got permanently closed when I tried to close and reopen it to re-trigger the Travis test since I had managed to delete the repository that submitted the PR. It seemed the Travis test failed for something unrelated to this minor code change.)