Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement REST API #14

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Implement REST API #14

merged 10 commits into from
Sep 20, 2024

Conversation

RonAzar
Copy link
Owner

@RonAzar RonAzar commented Sep 8, 2024

Added GET, POST, PUT, and DELETE endpoints.
Tested API using Postman.

@RonAzar RonAzar requested a review from brainpicker September 8, 2024 18:21
brainpicker
brainpicker reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@brainpicker brainpicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. The code is very organized. I liked that you went above and beyond to handle id's and faking the list yourself.

src/main/kotlin/com/hibob/academy/rest_api/OwnerResource.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hibob/academy/rest_api/OwnerResource.kt Show resolved Hide resolved
src/main/kotlin/com/hibob/academy/rest_api/OwnerResource.kt Show resolved Hide resolved
src/main/kotlin/com/hibob/academy/rest_api/OwnerResource.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hibob/academy/rest_api/PetController.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hibob/academy/rest_api/PetController.kt Outdated Show resolved Hide resolved
@RonAzar
Gady's Review- If the url is /pets/{petId} then usually it means that…
10f2cc1 
… you want all or some details of the pet. In your case if you are just returning the type I would change the url to reflect this.
@RonAzar
Gady's Review-I think since the Pet is not a complex class and only c…
53ce942 
…onsists of basic parameters types, you can probably use Response.ok().entity(pet).build() and it will serialize the object already to a readable string.
@RonAzar
Gady's Review-The more kotlin way would be do do owner?.let { } ?: th…
91b4e81 
…row Exception
@RonAzar RonAzar requested a review from brainpicker September 9, 2024 19:42
brainpicker
brainpicker approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@brainpicker brainpicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Just please watch the styling. There is a lot of mess and inconsistency. The IntelliJ allows to re-format before committing in the dialog. Or you can just format the code yourself manually.

@RonAzar RonAzar merged commit f87c415 into master Sep 20, 2024
0 of 2 checks passed
@RonAzar RonAzar deleted the rest-api-gadi-lesson branch September 20, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainpicker brainpicker brainpicker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonAzar @brainpicker