Code

Implement REST API#14

Code

Merged

RonAzar merged 10 commits intomasterRonAzar/hibob-academy:masterfrom rest-api-gadi-lessonRonAzar/hibob-academy:rest-api-gadi-lessonCopy head branch name to clipboardSep 20, 2024

+181

Commits

Commits on Sep 8, 2024

• Dummy

  RonAzar

  committed
  cd4bebe

• Implement REST API

  RonAzar

  committed
  53ec4ca

Commits on Sep 9, 2024

• Gady's Review- If the url is /pets/{petId} then usually it means that you want all or some details of the pet. In your case if you are just returning the type I would change the url to reflect this.

  RonAzar

  committed
  10f2cc1

• Gady's Review-I think since the Pet is not a complex class and only consists of basic parameters types, you can probably use Response.ok().entity(pet).build() and it will serialize the object alrea…

  Show description for 53ce942
  RonAzar

  committed
  53ce942

• Gady's Review-The more kotlin way would be do do owner?.let { } ?: throw Exception

  RonAzar

  committed
  91b4e81

Commits on Sep 10, 2024

• Gady review - /envelopes shouldn't be part of the path.

  RonAzar

  committed
  66f27ef

• Fixed!

  RonAzar

  committed
  ddc9df7

Commits on Sep 12, 2024

• delete comment

  RonAzar

  committed
  a2630ea

Commits on Sep 16, 2024

• No need envelopes here either.

  RonAzar

  committed
  2274ccb

Commits on Sep 18, 2024

• Sending all REST API calls In custom serialization (#15)

  RonAzar

  authored
  97f2e24