-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Drawer): Migrate to styled-components
#1862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7kvqbe1
added
Type: Enhancement
New feature or request
Package: react-component-library
Package/code type
labels
Jan 14, 2021
m7kvqbe1
force-pushed
the
refactor/drawer-styled-components
branch
from
January 18, 2021 12:11
fabf5c0
to
6179fa6
Compare
m7kvqbe1
changed the title
[WIP] refactor(Drawer): Migrate to
refactor(Drawer): Migrate to Jan 18, 2021
styled-components
styled-components
Code Climate has analyzed commit 6179fa6 and detected 0 issues on this pull request. View more on Code Climate. |
I've had to add skips to some tests - see the following issue: styled-components/jest-styled-components#335 |
thyhjwb6
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1852
Overview
Migrate
Drawer
to styled-components.Reason
Migrating all components.