[WIP] symbolic: Workaround for numpy#10876 #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my normal visibility on github notifications is severely crippled this week. please feel free to ping me when the prereqs are met. thanks! |
|
@EricCousineau-TRI -- what's the current state of this one? |
|
Still dependent on RobotLocomotion/drake#8452; I've not put much effort behind it aside from maybe 2 hrs in the past few months. Want me to try and get that merged in? |
|
not urgent for me. just making sure the PR is not obsolete. |
RussTedrake
force-pushed
the
master
branch
13 times, most recently
from
d92aa0f to
b052bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates RobotLocomotion/drake#8452
This works around numpy/numpy#10876 (numpy/numpy#9028) by explicitly using
Expressionwithnp.dot, sincenp.dotcannot be used withVariableas it is not closed under addition / subtraction.This should be merged in if/when the above Drake PR lands.
This passes locally on my machine when using the following PR commit for NumPy: numpy/numpy#10898
This change is