-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use user-defined NumPy dtypes for AutoDiffXd, Expression, etc. #8452
[WIP] Use user-defined NumPy dtypes for AutoDiffXd, Expression, etc. #8452
Conversation
ecaae88
to
617ce19
Compare
@RussTedrake The main backwards-incompatible change this introduces is that Is that OK? |
yuck, but I understand . if you think that this is the best outcome, i can live with it. |
I do believe the other benefits outweigh this cost, but I've submitted numpy/numpy#10876 as a request. |
499e578
to
5b552db
Compare
a37a1be
to
dc7f4b1
Compare
@jwnimmer-tri This PR has an initial incantation of building NumPy from an upstream PR and using the resulting wheel in a build. Do you think I should lump the NumPy repository stuff all together in this PR, or make a separate one? EDIT: Er, |
06eace3
to
395deab
Compare
+@jwnimmer-tri for feature review, if you have time. Review status: 0 of 45 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Even setting aside the four commits that are from #8608, this PR seems quite large. Perhaps it makes sense just do to "autodiff: Use user-defined dtype" (+ the pybind11 bump) as the next PR in this train? (Or symbolic instead of autodiff, if that was better somehow.) |
Yuppers, can do! |
@EricCousineau-TRI -- last activity on this PR was in May. Do you want to keep it open? |
Yes, I would like to keep this open. Once deadlines settle down here, I'd like to finish this up, especially in light of MultibodyTree, and supporting autodiff (and eventually symbolic) for them. |
@EricCousineau-TRI assigned to you for PR hygiene. |
9de4749
to
cb99c74
Compare
6770690
to
8166ac3
Compare
14c82df
to
4937a46
Compare
b809fa6
to
4ef7baf
Compare
4ef7baf
to
ab1735e
Compare
Closing for now. Can re-open later. |
Resolves #8116
See tracking issue for progress.
\cc @soonho-tri @RussTedrake
This change is