Generate samples at a multiple of channels #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
requested changes
Nov 16, 2019
src/source/pausable.rs
Outdated
| /// Sets whether the filter applies. | ||
| /// | ||
| /// If set to true, the inner sound stops playing and no samples are processed from it. | ||
| #[inline] | ||
| pub fn set_paused(&mut self, paused: bool) { | ||
| self.paused = paused; | ||
| // Minimize calls to channels by only calling on state change |
There was a problem hiding this comment.
This comment is wrong. You always call the function when paused is true, even if it was true before. In general, set_paused shouldn't be called often so minimizing calls shouldn't be needed. I'd say you should just remove the comment.
src/source/pausable.rs
Outdated
| Pausable { | ||
| input: source, | ||
| paused: paused, | ||
| paused_channels: paused_channels, |
Closed
|
I think I fixed those issues. Long term using something like the sample crates Frame trait would avoid these issues at the type level, but that's a big change to the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where pausing and unpausing would swap the channels of a stereo source. It was because the number of samples the pause source generated while paused wasn't a multiple of 2. This has two fixes for that issue.
One Pausable now always generates Zero's in a multiple of the number of channels.
Two Periodic only changes things at a multiple of the number of channels. This might help other similar issues.
I also fixed Delay since it has the same potential issue.
I suspect channel ordering issues can also occur if current_frame_len isn't a multiple of the channels, when called before iterating. Also if the iterator returns a None that's not aligned with current_frame_len. Those could cause the issue with Repeat, Stop and various ways of chaining Sources.