k256/p256: add sec1::EncodedPoint::decompress test #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 58.50% 58.70% +0.19%
==========================================
Files 25 25
Lines 3767 3775 +8
==========================================
+ Hits 2204 2216 +12
+ Misses 1563 1559 -4
Continue to review full report at Codecov.
|
Add tests that the upstream `sec1::EncodedPoint::decompress` method works given the trait impls in the respective crates. The generic upstream implementation was previously broken: RustCrypto/traits#309 The plan is to release `elliptic-curve` v0.6.1 with the above fix, then yank the broken v0.6.1 release.
tarcieri
force-pushed
the
test-point-decompression
branch
from
d591632 to
828cdae
Compare
This was referenced Sep 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests that the upstream
sec1::EncodedPoint::decompressmethod works given the trait impls in the respective crates.The generic upstream implementation was previously broken:
RustCrypto/traits#309
The plan is to release
elliptic-curvev0.6.1 with the above fix, then yank the broken v0.6.1 release.