elliptic-curve: fix sec1::EncodedPoint::decompress
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was previously expecting `Decompress` and `ToEncodedPoint` impls on `Scalar`, rather than `AffinePoint`. This updates it to use the correct types.
|
This is technically a breaking change as it alters the trait bounds, however the original implementation was buggy, so there's nothing to "break" here. I would suggest yanking |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 21, 2020
Add tests that the upstream `sec1::EncodedPoint::decompress` method works given the trait impls in the respective crates. The generic upstream implementation was previously broken: RustCrypto/traits#309 The plan is to release `elliptic-curve` v0.6.1 with the above fix, then yank the broken v0.6.1 release.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 21, 2020
Add tests that the upstream `sec1::EncodedPoint::decompress` method works given the trait impls in the respective crates. The generic upstream implementation was previously broken: RustCrypto/traits#309 The plan is to release `elliptic-curve` v0.6.1 with the above fix, then yank the broken v0.6.1 release.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Sep 21, 2020
Add tests that the upstream `sec1::EncodedPoint::decompress` method works given the trait impls in the respective crates. The generic upstream implementation was previously broken: RustCrypto/traits#309 The plan is to release `elliptic-curve` v0.6.1 with the above fix, then yank the broken v0.6.1 release.
Merged
|
Note: this method now has downstream tests in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was previously expecting
DecompressandToEncodedPointimpls onScalar, rather thanAffinePoint.This updates it to use the correct types.