Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize p256 #433

Closed
wants to merge 7 commits into from
Closed

Normalize p256 #433

wants to merge 7 commits into from

Conversation

x87-va
Copy link

@x87-va x87-va commented Sep 16, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #433 (b5f2f3b) into master (df71290) will increase coverage by 0.27%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   64.70%   64.98%   +0.27%     
==========================================
  Files          28       28              
  Lines        3598     3638      +40     
==========================================
+ Hits         2328     2364      +36     
- Misses       1270     1274       +4     
Impacted Files Coverage Δ
p256/src/ecdsa.rs 82.60% <0.00%> (-7.87%) ⬇️
p256/src/arithmetic/scalar.rs 82.55% <100.00%> (+1.54%) ⬆️
p256/src/arithmetic/util.rs 82.35% <100.00%> (+15.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df71290...b5f2f3b. Read the comment docs.

Comment on lines +32 to +33
num-bigint = "0.4"
num-traits = "0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit excessive to loop in num-bigint just for testing this. k256 does a number of other equivalence tests of the field arithmetic with it.

I think ideally we'd even get rid of those and move all of that sort of testing into a proptests crate or something.

For the purposes of testing this, I think it's fine to use crypto_bigint::UInt to compute the various boundary conditions and then check if they're low/high.

x87-va and others added 2 commits September 18, 2021 08:47
Co-authored-by: Tony Arcieri <bascule@gmail.com>
x87-va and others added 2 commits September 22, 2021 10:16
Co-authored-by: Tony Arcieri <bascule@gmail.com>
@tarcieri
Copy link
Member

I believe this is obsoleted by RustCrypto/signatures#393

@tarcieri tarcieri closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants