-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize p256 #433
Normalize p256 #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 64.70% 64.98% +0.27%
==========================================
Files 28 28
Lines 3598 3638 +40
==========================================
+ Hits 2328 2364 +36
- Misses 1270 1274 +4
Continue to review full report at Codecov.
|
num-bigint = "0.4" | ||
num-traits = "0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a bit excessive to loop in num-bigint
just for testing this. k256
does a number of other equivalence tests of the field arithmetic with it.
I think ideally we'd even get rid of those and move all of that sort of testing into a proptests
crate or something.
For the purposes of testing this, I think it's fine to use crypto_bigint::UInt
to compute the various boundary conditions and then check if they're low/high.
Co-authored-by: Tony Arcieri <bascule@gmail.com>
…into normalize_p256
Co-authored-by: Tony Arcieri <bascule@gmail.com>
…into normalize_p256
I believe this is obsoleted by RustCrypto/signatures#393 |
No description provided.