ecdsa: remove NormalizeLow trait
#393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The available curve arithmetic is now expressive enough that it's possible to implement `Signature::normalize_s` generically for all curves with a `ScalarArithmetic` backend. Because of that, we no longer need a special "helper trait" for this purpose, and so `NormalizeLow` can be removed.
This was referenced Nov 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available curve arithmetic is now expressive enough that it's possible to implement
Signature::normalize_sgenerically for all curves with aScalarArithmeticbackend.Because of that, we no longer need a special "helper trait" for this purpose, and so
NormalizeLowcan be removed.