Fix using sha2_asm on aarch64. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code doesn't compile before. Can use `cargo test --features asm` to verify. Tested on AWS Graviton2 server.
|
Note: we have pretty extensive https://github.com/RustCrypto/asm-hashes/blob/master/.github/workflows/sha2.yml |
Got it, that's cool! |
|
Thanks! We should definitely add |
tarcieri
added a commit
that referenced
this pull request
Nov 25, 2020
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
tarcieri
added a commit
that referenced
this pull request
Nov 25, 2020
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
tarcieri
added a commit
that referenced
this pull request
Nov 25, 2020
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
tarcieri
added a commit
that referenced
this pull request
Nov 25, 2020
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
tarcieri
added a commit
that referenced
this pull request
Nov 25, 2020
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code doesn't compile before.
Can use
cargo test --features asmto verify (on an aarch64 machine).Tested on AWS Graviton2 server.
Btw, the current GitHub Action testing scripts failed to cover this case. Because GitHub Actions are hosted on x86 machines.
If want to test on different architectures, maybe we need to setup QEMU to emulate.